Re: [PULL 53/53] vhost-vdpa: do not cleanup the vdpa/vhost-net structures if peer nic is present

2023-06-26 Thread Ani Sinha
> On 26-Jun-2023, at 9:23 PM, Michael Tokarev wrote: > > 26.06.2023 15:30, Michael S. Tsirkin wrote: >> From: Ani Sinha >> When a peer nic is still attached to the vdpa backend, it is too early to >> free >> up the vhost-net and vdpa structures. If these structures are freed here, >> then >

Re: [PULL 53/53] vhost-vdpa: do not cleanup the vdpa/vhost-net structures if peer nic is present

2023-06-26 Thread Michael Tokarev
26.06.2023 15:30, Michael S. Tsirkin wrote: From: Ani Sinha When a peer nic is still attached to the vdpa backend, it is too early to free up the vhost-net and vdpa structures. If these structures are freed here, then QEMU crashes when the guest is being shut down. The following call chain woul

[PULL 53/53] vhost-vdpa: do not cleanup the vdpa/vhost-net structures if peer nic is present

2023-06-26 Thread Michael S. Tsirkin
From: Ani Sinha When a peer nic is still attached to the vdpa backend, it is too early to free up the vhost-net and vdpa structures. If these structures are freed here, then QEMU crashes when the guest is being shut down. The following call chain would result in an assertion failure since the poi