Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-08-19 Thread Christian Borntraeger
On 19.08.21 16:51, Christian Borntraeger wrote: On 19.08.21 10:43, Christian Borntraeger wrote: Interestingly enough this breaks my rpmbuild (both rpmbuild and mock). (mostly with a modified f35 spec file): cc -Isubprojects/libvhost-user/libvhost-user.a.p -Isubprojects/libvhost-user -I../s

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-08-19 Thread Christian Borntraeger
On 19.08.21 10:43, Christian Borntraeger wrote: Interestingly enough this breaks my rpmbuild (both rpmbuild and mock). (mostly with a modified f35 spec file): cc -Isubprojects/libvhost-user/libvhost-user.a.p -Isubprojects/libvhost-user -I../subprojects/libvhost-user -fdiagnostics-color=auto -

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-08-19 Thread Christian Borntraeger
Interestingly enough this breaks my rpmbuild (both rpmbuild and mock). (mostly with a modified f35 spec file): cc -Isubprojects/libvhost-user/libvhost-user.a.p -Isubprojects/libvhost-user -I../subprojects/libvhost-user -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -std=gnu11 -O2 -g -U_FORTI

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Yonggang Luo
Relative symlink should work on Windows. Only symlink that points to non-exist file would file. On Thu, Jul 29, 2021 at 11:09 PM Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 15:05, Thomas Huth wrote: > > > > On 29/07/2021 14.58, Peter Maydell wrote: > > > On Thu, 29 Jul 2021 at 13:56, Paolo B

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 15:05, Thomas Huth wrote: > > On 29/07/2021 14.58, Peter Maydell wrote: > > On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: > >> > >> From: Marc-André Lureau > >> > >> Meson now checks that subprojects do not access files from parent > >> project. While we all agree thi

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Thomas Huth
On 29/07/2021 14.58, Peter Maydell wrote: On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: From: Marc-André Lureau Meson now checks that subprojects do not access files from parent project. While we all agree this is best practice, libvhost-user also want to share a few headers with QEMU,

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Peter Maydell
On Thu, 29 Jul 2021 at 13:56, Paolo Bonzini wrote: > > From: Marc-André Lureau > > Meson now checks that subprojects do not access files from parent > project. While we all agree this is best practice, libvhost-user also > want to share a few headers with QEMU, and libvhost-user isn't really a >

[PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-07-29 Thread Paolo Bonzini
From: Marc-André Lureau Meson now checks that subprojects do not access files from parent project. While we all agree this is best practice, libvhost-user also want to share a few headers with QEMU, and libvhost-user isn't really a standalone project at this point (although this is making the dep