Re: [PULL V2 01/23] dp8393x: Mask EOL bit from descriptor addresses

2020-03-03 Thread Jason Wang
On 2020/3/4 上午6:44, Finn Thain wrote: Hi Jason, The patch in this pull request (since merged) differs from the patch that I sent. In particular, the change below is missing from commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses") in mainline. --- a/hw/net/dp8393x.c +++ b/hw/

Re: [PULL V2 01/23] dp8393x: Mask EOL bit from descriptor addresses

2020-03-03 Thread Finn Thain
Hi Jason, The patch in this pull request (since merged) differs from the patch that I sent. In particular, the change below is missing from commit 88f632fbb1 ("dp8393x: Mask EOL bit from descriptor addresses") in mainline. --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -525,8 +525,8 @@ static

[PULL V2 01/23] dp8393x: Mask EOL bit from descriptor addresses

2020-03-03 Thread Jason Wang
From: Finn Thain The Least Significant bit of a descriptor address register is used as an EOL flag. It has to be masked when the register value is to be used as an actual address for copying memory around. But when the registers are to be updated the EOL bit should not be masked. Signed-off-by: