Re: [PULL v2 00/61] Misc patches for soft freeze

2020-03-17 Thread Philippe Mathieu-Daudé
On 3/17/20 3:47 PM, Paolo Bonzini wrote: On 17/03/20 15:26, Stefan Hajnoczi wrote: Yes, looks like the compiler can't figure out the control flow on NetBSD. We could drop the WITH_QEMU_LOCK_GUARD() macro and use this idiom instead: { QEMU_LOCK_GUARD(&mutex); ... } But it's

Re: [PULL v2 00/61] Misc patches for soft freeze

2020-03-17 Thread Paolo Bonzini
On 17/03/20 15:26, Stefan Hajnoczi wrote: > Yes, looks like the compiler can't figure out the control flow on > NetBSD. > > We could drop the WITH_QEMU_LOCK_GUARD() macro and use this idiom > instead: > > { > QEMU_LOCK_GUARD(&mutex); > ... > } > > But it's unusual for C code to c

Re: [PULL v2 00/61] Misc patches for soft freeze

2020-03-17 Thread Stefan Hajnoczi
On Tue, Mar 17, 2020 at 01:02:48PM +0100, Philippe Mathieu-Daudé wrote: > Cc'ing Stefan > > On 3/17/20 12:03 PM, Peter Maydell wrote: > > On Mon, 16 Mar 2020 at 22:07, Paolo Bonzini wrote: > > > > > > The following changes since commit > > > a98135f727595382e200d04c2996e868b7925a01: > > > > >

Re: [PULL v2 00/61] Misc patches for soft freeze

2020-03-17 Thread Philippe Mathieu-Daudé
Cc'ing Stefan On 3/17/20 12:03 PM, Peter Maydell wrote: On Mon, 16 Mar 2020 at 22:07, Paolo Bonzini wrote: The following changes since commit a98135f727595382e200d04c2996e868b7925a01: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200316-pull-request' into staging (2020-03-16 14

Re: [PULL v2 00/61] Misc patches for soft freeze

2020-03-17 Thread Peter Maydell
On Mon, 16 Mar 2020 at 22:07, Paolo Bonzini wrote: > > The following changes since commit a98135f727595382e200d04c2996e868b7925a01: > > Merge remote-tracking branch > 'remotes/kraxel/tags/vga-20200316-pull-request' into staging (2020-03-16 > 14:55:59 +) > > are available in the git reposit

[PULL v2 00/61] Misc patches for soft freeze

2020-03-16 Thread Paolo Bonzini
The following changes since commit a98135f727595382e200d04c2996e868b7925a01: Merge remote-tracking branch 'remotes/kraxel/tags/vga-20200316-pull-request' into staging (2020-03-16 14:55:59 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream fo