Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-21 Thread Philippe Mathieu-Daudé
On 3/21/20 12:05 PM, Philippe Mathieu-Daudé wrote: On 3/20/20 5:37 PM, Peter Maydell wrote: On Fri, 20 Mar 2020 at 16:32, Philippe Mathieu-Daudé wrote: -fwrapv is here indeed. I use --extra-cflags=-fsanitize=address,alignment,array-bounds,bool,builtin,enum,float-cast-overflow,float-divide-by-

Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-21 Thread Philippe Mathieu-Daudé
On 3/20/20 5:37 PM, Peter Maydell wrote: On Fri, 20 Mar 2020 at 16:32, Philippe Mathieu-Daudé wrote: -fwrapv is here indeed. I use --extra-cflags=-fsanitize=address,alignment,array-bounds,bool,builtin,enum,float-cast-overflow,float-divide-by-zero,function,integer-divide-by-zero,nonnull-attribu

Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Peter Maydell
On Fri, 20 Mar 2020 at 16:32, Philippe Mathieu-Daudé wrote: > -fwrapv is here indeed. > > I use > --extra-cflags=-fsanitize=address,alignment,array-bounds,bool,builtin,enum,float-cast-overflow,float-divide-by-zero,function,integer-divide-by-zero,nonnull-attribute,null,pointer-overflow,return,retur

Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/20/20 5:21 PM, Peter Maydell wrote: On Fri, 20 Mar 2020 at 16:19, Richard Henderson wrote: On 3/20/20 9:04 AM, Philippe Mathieu-Daudé wrote: Not related to this patch, but this line generates a warning with Clang: CC rx-softmmu/target/rx/cpu.o target/rx/cpu.c:158:33: warning: Th

Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Peter Maydell
On Fri, 20 Mar 2020 at 16:19, Richard Henderson wrote: > > On 3/20/20 9:04 AM, Philippe Mathieu-Daudé wrote: > > Not related to this patch, but this line generates a warning with Clang: > > > > CC rx-softmmu/target/rx/cpu.o > > target/rx/cpu.c:158:33: warning: The result of the left shift i

Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Richard Henderson
On 3/20/20 9:04 AM, Philippe Mathieu-Daudé wrote: > Not related to this patch, but this line generates a warning with Clang: > >   CC  rx-softmmu/target/rx/cpu.o > target/rx/cpu.c:158:33: warning: The result of the left shift is undefined > because the left operand is negative >     address =

Re: [PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Philippe Mathieu-Daudé
On 3/20/20 11:35 AM, Philippe Mathieu-Daudé wrote: From: Yoshinori Sato Reviewed-by: Richard Henderson Signed-off-by: Yoshinori Sato Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable array, use rx_cpu_tlb_fill() extracted from patch of

[PULL v2 05/13] target/rx: CPU definitions

2020-03-20 Thread Philippe Mathieu-Daudé
From: Yoshinori Sato Reviewed-by: Richard Henderson Signed-off-by: Yoshinori Sato Signed-off-by: Richard Henderson [PMD: Use newer QOM style, split cpu-qom.h, restrict access to extable array, use rx_cpu_tlb_fill() extracted from patch of Yoshinori Sato 'Convert to CPUClass::tlb_fill', call