Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-27 Thread Igor Mammedov
On Wed, 18 Oct 2023 18:38:33 +0100 Salil Mehta wrote: > Hello, > Can we assume that every machine type will have all the features which a > GED Device can multiplex present together? like will Memory and CPU > Hotplug makes sense for all the type of machines? > > If answer is no, then

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-27 Thread Igor Mammedov
On Sat, 21 Oct 2023 00:54:56 +0100 Salil Mehta wrote: > Hi Bernhard, > > On 19/10/2023 11:33, Bernhard Beschow wrote: > > > > > > Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta > > : > >> Hello, > > > > Hi Salil, > > > >> Can we assume that every machine type will have all the

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-20 Thread Salil Mehta
Hi Bernhard, On 19/10/2023 11:33, Bernhard Beschow wrote: Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta : Hello, Hi Salil, Can we assume that every machine type will have all the features which a GED Device can multiplex present together? like will Memory and CPU Hotplug makes

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-19 Thread Michael S. Tsirkin
On Thu, Oct 19, 2023 at 10:33:08AM +, Bernhard Beschow wrote: > > > Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta : > >Hello, > > Hi Salil, > > >Can we assume that every machine type will have all the features which a GED > >Device can multiplex present together? like will Memory

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-19 Thread Bernhard Beschow
Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta : >Hello, Hi Salil, >Can we assume that every machine type will have all the features which a GED >Device can multiplex present together? like will Memory and CPU Hotplug makes >sense for all the type of machines? I can't really answer

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-18 Thread Salil Mehta
Hello, Can we assume that every machine type will have all the features which a GED Device can multiplex present together? like will Memory and CPU Hotplug makes sense for all the type of machines? If answer is no, then shouldn't every machine type override the base GED type and define it

[PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-04 Thread Michael S. Tsirkin
From: Bernhard Beschow Now that TYPE_ACPI_GED_X86 doesn't assign AcpiDeviceIfClass::madt_cpu any more it is the same as TYPE_ACPI_GED. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230908084234.17642-6-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin