Re: [PULL v3 58/85] hw/i386/fw_cfg: Add etc/e820 to fw_cfg late

2024-07-04 Thread Alex Bennée
David Woodhouse writes: > On Wed, 2024-07-03 at 18:48 -0400, Michael S. Tsirkin wrote: >> From: David Woodhouse > > Oops, that was supposed to be > > From: David Woodhouse > > Not the end of the world if it's too late to change it. If attribution matters we do have .mailmap and the gitdm

Re: [PULL v3 58/85] hw/i386/fw_cfg: Add etc/e820 to fw_cfg late

2024-07-04 Thread David Woodhouse
On Wed, 2024-07-03 at 18:48 -0400, Michael S. Tsirkin wrote: > From: David Woodhouse Oops, that was supposed to be From: David Woodhouse Not the end of the world if it's too late to change it. smime.p7s Description: S/MIME cryptographic signature

[PULL v3 58/85] hw/i386/fw_cfg: Add etc/e820 to fw_cfg late

2024-07-03 Thread Michael S. Tsirkin
From: David Woodhouse In e820_add_entry() the e820_table is reallocated with g_renew() to make space for a new entry. However, fw_cfg_arch_create() just uses the existing e820_table pointer. This leads to a use-after-free if anything adds a new entry after fw_cfg is set up. Shift the addition