Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-11 Thread Igor Mammedov
On Fri, 11 Nov 2022 10:43:30 +0100 Igor Mammedov wrote: > On Thu, 10 Nov 2022 09:28:44 + > Peter Maydell wrote: > > > On Wed, 9 Nov 2022 at 21:42, Michael S. Tsirkin wrote: > > > > > > > diff --git a/hw/display/meson.build b/hw/display/meson.build > > > > > index adc53dd8b6..7a725ed80e

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-11 Thread Igor Mammedov
On Thu, 10 Nov 2022 09:28:44 + Peter Maydell wrote: > On Wed, 9 Nov 2022 at 21:42, Michael S. Tsirkin wrote: > > > > > diff --git a/hw/display/meson.build b/hw/display/meson.build > > > > index adc53dd8b6..7a725ed80e 100644 > > > > --- a/hw/display/meson.build > > > > +++

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-10 Thread Peter Maydell
On Wed, 9 Nov 2022 at 21:42, Michael S. Tsirkin wrote: > > > diff --git a/hw/display/meson.build b/hw/display/meson.build > > > index adc53dd8b6..7a725ed80e 100644 > > > --- a/hw/display/meson.build > > > +++ b/hw/display/meson.build > > > @@ -38,10 +38,21 @@ softmmu_ss.add(when:

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-09 Thread Ani Sinha
On Wed, Nov 9, 2022 at 11:09 PM Laurent Vivier wrote: > > This one breaks something for me: > > [3/65] Compiling C object > libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o > FAILED: libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o > clang -m64 -mcx16

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-09 Thread Michael S. Tsirkin
On Wed, Nov 09, 2022 at 06:39:27PM +0100, Laurent Vivier wrote: > This one breaks something for me: > > [3/65] Compiling C object > libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o > FAILED: libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o > clang -m64 -mcx16

Re: [PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-09 Thread Laurent Vivier
This one breaks something for me: [3/65] Compiling C object libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o FAILED: libhw-display-virtio-vga-gl.a.p/hw_display_acpi-vga.c.o clang -m64 -mcx16 -Ilibhw-display-virtio-vga-gl.a.p -I. -I../../../Projects/qemu-upstream -Iqapi -Itrace -Iui

[PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors

2022-11-07 Thread Michael S. Tsirkin
From: Igor Mammedov NB: We do not expect any functional change in any ACPI tables with this change. It's only a refactoring. NB2: Some targets (or1k) do not support acpi and CONFIG_ACPI is off for them. However, modules are reused between all architectures so CONFIG_ACPI is on. For those