[Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-21 Thread Kevin Wolf
Hi all, I'm currently looking into adding a return value to qemu's bdrv_flush function and I noticed that your block drivers (nbd, rbd and sheepdog) don't implement bdrv_flush at all. bdrv_flush is going to return -ENOTSUP for any block driver not implementing this, effectively breaking these thre

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-21 Thread Anthony Liguori
On 10/21/2010 09:07 AM, Kevin Wolf wrote: Hi all, I'm currently looking into adding a return value to qemu's bdrv_flush function and I noticed that your block drivers (nbd, rbd and sheepdog) don't implement bdrv_flush at all. bdrv_flush is going to return -ENOTSUP for any block driver not implem

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-21 Thread Laurent Vivier
Le jeudi 21 octobre 2010 à 10:07 -0500, Anthony Liguori a écrit : > On 10/21/2010 09:07 AM, Kevin Wolf wrote: > > Hi all, > > > > I'm currently looking into adding a return value to qemu's bdrv_flush > > function and I noticed that your block drivers (nbd, rbd and sheepdog) > > don't implement bdrv

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-21 Thread MORITA Kazutaka
At Thu, 21 Oct 2010 16:07:28 +0200, Kevin Wolf wrote: > > Hi all, > > I'm currently looking into adding a return value to qemu's bdrv_flush > function and I noticed that your block drivers (nbd, rbd and sheepdog) > don't implement bdrv_flush at all. bdrv_flush is going to return > -ENOTSUP for an

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 21.10.2010 21:32, schrieb Laurent Vivier: > Le jeudi 21 octobre 2010 à 10:07 -0500, Anthony Liguori a écrit : >> On 10/21/2010 09:07 AM, Kevin Wolf wrote: >>> Hi all, >>> >>> I'm currently looking into adding a return value to qemu's bdrv_flush >>> function and I noticed that your block drivers

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 07:43, schrieb MORITA Kazutaka: > At Thu, 21 Oct 2010 16:07:28 +0200, > Kevin Wolf wrote: >> >> Hi all, >> >> I'm currently looking into adding a return value to qemu's bdrv_flush >> function and I noticed that your block drivers (nbd, rbd and sheepdog) >> don't implement bdrv_flush a

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is. However, I did have a look at the nbdserver code and it looks as if it implements something similar to writethr

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 14:58, schrieb Anthony Liguori: > On 10/22/2010 03:29 AM, Kevin Wolf wrote: >>> I agree. >>> >> Of course, as Laurent said a while ago, there is no specification for >> NBD, so it's hard to say what the intended semantics is. >> >> However, I did have a look at the nbdserver cod

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:35 AM, Kevin Wolf wrote: Am 22.10.2010 14:58, schrieb Anthony Liguori: On 10/22/2010 03:29 AM, Kevin Wolf wrote: I agree. Of course, as Laurent said a while ago, there is no specification for NBD, so it's hard to say what the intended semantics is. Howeve

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:57 AM, Kevin Wolf wrote: Am 22.10.2010 15:45, schrieb Anthony Liguori: On a physical system, if you don't have a battery backed disk and you enable the WC on your disk, then even with cache=writethrough we're unsafe. I don't think that's right. O_SYNC should guar

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
Am 22.10.2010 15:45, schrieb Anthony Liguori: >>> On a physical system, if you don't have a battery backed disk and you >>> enable the WC on your disk, then even with cache=writethrough we're unsafe. >>> >> I don't think that's right. O_SYNC should guarantee that the volatile >> disk cache is

Re: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-24 Thread MORITA Kazutaka
At Fri, 22 Oct 2010 10:47:44 +0200, Kevin Wolf wrote: > > Am 22.10.2010 07:43, schrieb MORITA Kazutaka: > > At Thu, 21 Oct 2010 16:07:28 +0200, > > Kevin Wolf wrote: > >> > >> Hi all, > >> > >> I'm currently looking into adding a return value to qemu's bdrv_flush > >> function and I noticed that y

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Kevin Wolf
warded message -- >> From: Kevin Wolf >> Date: 2010/10/21 >> Subject: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog >> To: Christian Brunner , Laurent Vivier >> , MORITA Kazutaka >> Cc: Qemu-devel@nongnu.org >> >> >

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-22 Thread Sage Weil
oblem, though, so it's your decision if you want to implement it. So is a bdrv_flush generated when e.g. the guest filesystem issues a barrier, or would otherwise normally ask a SATA disk to flush it's cache? sage > Kevin > > >> -- Forwarded message

Re: Fwd: [Qemu-devel] bdrv_flush for qemu block drivers nbd, rbd and sheepdog

2010-10-25 Thread Kevin Wolf
Am 22.10.2010 18:22, schrieb Sage Weil: > On Fri, 22 Oct 2010, Kevin Wolf wrote: >> [ Adding qemu-devel to CC again ] >> >> Am 21.10.2010 20:59, schrieb Sage Weil: >>> On Thu, 21 Oct 2010, Christian Brunner wrote: Hi, is there a flush operation in librados? - I guess the only way to