Re: [Qemu-devel] [Bug 1464611] [NEW] 4 * redundant conditions

2015-06-12 Thread Eric Blake
On 06/12/2015 05:01 AM, Peter Maydell wrote: 4. [qemu/target-arm/translate-a64.c:5729]: (style) Redundant condition: size3. 'A (!A || B)' is equivalent to 'A || B' if (size 3 || (size 3 is_q) || (size == 3 !is_q)) { ...but I'm less sure about this

Re: [Qemu-devel] [Bug 1464611] [NEW] 4 * redundant conditions

2015-06-12 Thread Peter Maydell
On 12 June 2015 at 14:03, Eric Blake ebl...@redhat.com wrote: On 06/12/2015 05:01 AM, Peter Maydell wrote: 4. [qemu/target-arm/translate-a64.c:5729]: (style) Redundant condition: size3. 'A (!A || B)' is equivalent to 'A || B' if (size 3 || (size 3 is_q)

[Qemu-devel] [Bug 1464611] [NEW] 4 * redundant conditions

2015-06-12 Thread dcb
Public bug reported: 1. [qemu/hw/block/nvme.c:355]: (style) Redundant condition: sqid. 'A (!A || B)' is equivalent to 'A || B' if (!sqid || (sqid !nvme_check_sqid(n, sqid))) { 2. [qemu/hw/block/nvme.c:429]: (style) Redundant condition: cqid. 'A (!A || B)' is equivalent to 'A || B' if

Re: [Qemu-devel] [Bug 1464611] [NEW] 4 * redundant conditions

2015-06-12 Thread Peter Maydell
On 12 June 2015 at 11:38, dcb 1464...@bugs.launchpad.net wrote: Public bug reported: 1. [qemu/hw/block/nvme.c:355]: (style) Redundant condition: sqid. 'A (!A || B)' is equivalent to 'A || B' if (!sqid || (sqid !nvme_check_sqid(n, sqid))) { 2. [qemu/hw/block/nvme.c:429]: (style)