[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2017-12-15 Thread Thomas Huth
** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1599539 Title: 2.6.0: vvfat driver generates bad FAT entries Status in QEMU: Fix Released

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2017-08-30 Thread Thomas Huth
Another patch has apparently been included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=f80256b7eebfbe20683 I assume we can close this ticket now as fixed? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2017-08-19 Thread felix
I believe commits f82d92bb028a1d674bab4ccc7e6cde6c04956230 and 6817efea3a0d1bf87be815970cdb014c5a64b628 have fixed this particular bug; although I've since noticed the vvfat driver remains quite fragile, especially FAT32 and writing support. I've got some patches for it of my own, which I might

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-08-11 Thread Kevin Wolf
Thanks for looking into this, Felix. If you think that your fix to read_directory() is ready for inclusion, please do send the patch to both the qemu-devel and qemu-block mailing lists as Thomas suggested. As each patch should address a single point, this can be done even while the second problem

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-08-10 Thread felix
The original issue turned out to be trivial. The dot and dot-dot entries need to be the two very first entries in a non-root directory table; however, readdir() does not guarantee that "." and ".." will be the first items returned. When I patched read_directory() to generate "." and ".." entries

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-07-25 Thread felix
I noticed another bug in vvfat disk image generation. Applying the patch I attached earlier made testing easier. I'm less sure what the actual problem is. Steps to reproduce (you'll need to have cpio, md5sum and GNU GRUB 2.x installed): 0. Apply the patch and build qemu-img. 1. Create a

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-07-25 Thread T. Huth
Please send your patch to the qemu-devel (and qemu-block) mailing list. See http://qemu-project.org/Contribute/SubmitAPatch for details on how to submit a patch. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1599539] Re: 2.6.0: vvfat driver generates bad FAT entries

2016-07-25 Thread felix
** Patch added: "Patch to fix the qemu-img issue (does NOT resolve the whole bug)" https://bugs.launchpad.net/qemu/+bug/1599539/+attachment/4707063/+files/make_vvfat_work_with_qemu-img.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is