Re: [Qemu-devel] [Bug 1798780] [NEW] hw/usb/dev-mtp.c:1616: bad test ?

2019-01-22 Thread Bandan Das
Peter Maydell writes: > On Fri, 19 Oct 2018 at 10:22, dcb <1798...@bugs.launchpad.net> wrote: >> hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively >> exhaustive tests is always true [-Wlogical-op] >> >> Source code is >> >> if ((ret == -1) && (errno != EINTR || errno

Re: [Qemu-devel] [Bug 1798780] [NEW] hw/usb/dev-mtp.c:1616: bad test ?

2019-01-18 Thread Peter Maydell
On Fri, 19 Oct 2018 at 10:22, dcb <1798...@bugs.launchpad.net> wrote: > hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively > exhaustive tests is always true [-Wlogical-op] > > Source code is > > if ((ret == -1) && (errno != EINTR || errno != EAGAIN || >

[Qemu-devel] [Bug 1798780] [NEW] hw/usb/dev-mtp.c:1616: bad test ?

2018-10-19 Thread dcb
Public bug reported: hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] Source code is if ((ret == -1) && (errno != EINTR || errno != EAGAIN || errno != EWOULDBLOCK)) { Maybe better c