[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-08-15 Thread Thomas Huth
Patch included here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=4ace32e22713ffd79deb22 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-08-02 Thread Peter Maydell
Antonio's patches are in git and will be in the upcoming 4.1.0 release. ** Changed in: qemu Status: In Progress => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817345 Title:

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-05-03 Thread Peter Maydell
Antonio has submitted a patchset here: https://patchew.org/QEMU/20190503082728.16485-1-...@ao2.it/ ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-03-09 Thread Deepika Choudhary
Oh~ Okay! On Sun, Mar 10, 2019, 02:30 Peter Maydell wrote: > Deepika: the tricky part is the makefiles, not the configure script... > > -- > You received this bug notification because you are subscribed to the bug > report. > https://bugs.launchpad.net/bugs/1817345 > > Title: > configure

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-03-09 Thread Peter Maydell
Deepika: the tricky part is the makefiles, not the configure script... -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1817345 Title: configure script breaks when $source_path contains white spaces

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-03-09 Thread Deepika Choudhary
If calling from any Unix shell, and the parameter has spaces, then we need to quote it.we can also use single quotes, these are more powerful. They stop the shell from interpreting anything ($, !, \, *, ", etc, except '). can't we use this approach here?? -- You received this bug notification

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-02-24 Thread Antonio Ospite
I am OK with just checking and complaining. Linux too solves the problem in this way: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Makefile?id=51193b76bfff5027cf96ba63effae808ad67cca7 A general "shellcheck" pass wouldn't hurt, tho. Thank you, Antonio -- You

Re: [Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-02-24 Thread Peter Maydell
On Sun, 24 Feb 2019 at 19:46, Michael Tokarev <1817...@bugs.launchpad.net> wrote: > I think it is better to just disallow building in a path containing > spaces, -- there are so many packages and other tools that fails in this > config, might require lots of work to fix this AND to ensure all

[Qemu-devel] [Bug 1817345] Re: configure script breaks when $source_path contains white spaces

2019-02-24 Thread Michael Tokarev
I think it is better to just disallow building in a path containing spaces, -- there are so many packages and other tools that fails in this config, might require lots of work to fix this AND to ensure all future changes are still working, and there's an easy workaround Just my few cents. --