[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-12-24 Thread Peter Maydell
We fixed all our set-but-not-used warnings for QEMU 1.0. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/793317 Title: Large amount of write-o

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-06 Thread Christophe Fergeau
Patches were already sent to the ML, see the "[PATCH 00/14] More gcc 4.6 warnings fixes" and "[PATCH 0/3] Fix unused-but-set-variable warnings" threads -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/79

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Eli
Yeah, that would be incredibly useful. I just wrote down a list of approximate line numbers and filenames for them, as I needed it to compile so just inserted dummy if() statements to "access" the variables. There are also a bunch more than I posted, those were just examples. -- You received this

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Brad Hards
I'm still confused. hw/usb-ehci.c line 526 is just a variable declaration: uint8_t *pci_conf; Line 529 looks like an unused assignment, but nothing I see on line 526. Would it be possible for you to double check the work, and possible paste the error message instead of summarising them? Brad

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Eli
Whoa. I completely messed up there. It's usb-ehci.c, I just thought of usb-ohci.c off the top of my head as it was way back in the console logs. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/793317 T

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Brad Hards
Ok, looking at the first example (line 526), I see code that looks like: static inline int ohci_put_iso_td(OHCIState *ohci, uint32_t addr, struct ohci_iso_td *td) { return (put_dwords(ohci, addr, (uint32_t *)td, 4) && put_words(ohci, addr + 16, td-

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Eli
Yeah, i meant usb-ohci.c. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/793317 Title: Large amount of write-only variables Status in QEMU: New Bug description: Whenever I try to compile the s

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Brad Hards
I don't have a file called hw/usb_ochi.c. Did you mean hw/usb-ohci.c? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/793317 Title: Large amount of write-only variables Status in QEMU: New Bug de