[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-18 Thread Alexey Starikovskiy
Sorry for the noise, it appears I've checked on not clean 0.15.0 ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/874038 Title: ARM thumb2 does not p

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Peter Maydell
> 0.15.0 fails for me. Hmm. Works for me: pm215@canth:/tmp$ wget http://wiki.qemu.org/download/qemu-0.15.0.tar.gz [...] pm215@canth:/tmp$ tar xzf qemu-0.15.0.tar.gz pm215@canth:/tmp$ cd qemu-0.15.0/ pm215@canth:/tmp/qemu-0.15.0$ ./configure --target-list=arm-linux-user && make -j4 [...] pm215@c

Re: [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Alexey Starikovskiy
0.15.0 fails for me. On Mon, Oct 17, 2011 at 10:06 PM, Peter Maydell wrote: > Current git master works for me on that test program without your patch: > cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe > cam-vm-266:maverick:qemu$ echo $? > 0 > > (I tested on qemu-0.14 ju

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Peter Maydell
Current git master works for me on that test program without your patch: cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe cam-vm-266:maverick:qemu$ echo $? 0 (I tested on qemu-0.14 just to confirm that I'm running the test program correctly, and that indeed fails as I wo

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-17 Thread Alexey Starikovskiy
MVNS with immediate fails in attached test program at 0x82c0 location. My patch fixes that. ** Attachment added: "failed test for MVNS.IMM opcode" https://bugs.launchpad.net/qemu/+bug/874038/+attachment/2554573/+files/mvns_imm.exe -- You received this bug notification because you are a membe

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-14 Thread Peter Maydell
The existing code looks OK to me -- there's no need to call gen_set_CF_bit31() early because the inputs t0 and t1 to gen_thumb2_data_op() should always be distinct TCG values, and so gen_thumb2_data_op() will never trash t1. (There was a bug in this area involving ORN, but that was fixed in rev 295

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-14 Thread Alexey Starikovskiy
** Patch added: "fix for the problem" https://bugs.launchpad.net/bugs/874038/+attachment/2542719/+files/fix_carry_in_thumb2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/874038 Title: ARM thumb