Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-04 Thread Paolo Bonzini
Il 04/03/2014 03:47, Xuebing Wang ha scritto: include/exec/exec-all.h should ONLY be included in target-xxx/* - 'git grep -nw exec-all.h' confirms this Ok. Paolo Signed-off-by: Xuebing Wang xbi...@gmail.com --- cputlb.c |1 - tcg/README |2 +- tci.c |2 +- 3 files

Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-04 Thread Peter Maydell
On 4 March 2014 02:47, Xuebing Wang xbi...@gmail.com wrote: include/exec/exec-all.h should ONLY be included in target-xxx/* Why? This header file defines a number of functions and types that are used outside target-xxx/. At the moment we implicitly rely on cpu.h pulling them in. Maybe it would

Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-04 Thread Peter Maydell
On 4 March 2014 11:11, Peter Maydell peter.mayd...@linaro.org wrote: On 4 March 2014 02:47, Xuebing Wang xbi...@gmail.com wrote: include/exec/exec-all.h should ONLY be included in target-xxx/* Why? This header file defines a number of functions and types that are used outside target-xxx/.

[Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of exec-all.h

2014-03-03 Thread Xuebing Wang
include/exec/exec-all.h should ONLY be included in target-xxx/* - 'git grep -nw exec-all.h' confirms this Signed-off-by: Xuebing Wang xbi...@gmail.com --- cputlb.c |1 - tcg/README |2 +- tci.c |2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cputlb.c