Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Thu, May 03, 2018 at 12:26:36PM -0500, Eric Blake wrote: > [resend with updated list address and pruning addresses that bounced] > > Reviving this discussion, as it still seems useful to incorporate now that > BLOCK_STATUS is only recently part of the standard. Yeah. I thought we'd

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

[resend with updated list address and pruning addresses that bounced] Reviving this discussion, as it still seems useful to incorporate now that BLOCK_STATUS is only recently part of the standard. On 12/14/2016 11:09 AM, Wouter Verhelst wrote: One thing I've been thinking about that we

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Reviving this discussion, as it still seems useful to incorporate now that BLOCK_STATUS is only recently part of the standard. On 12/14/2016 11:09 AM, Wouter Verhelst wrote: One thing I've been thinking about that we might want to add: There may be cases where a server, in performing the

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Hi, Sorry too for long delay. 28.02.2018 16:08, Wouter Verhelst wrote: Hi, Sorry, I forgot to reply to this earlier. On Fri, Feb 16, 2018 at 10:10:59AM -0600, Eric Blake wrote: On 02/16/2018 07:53 AM, Vladimir Sementsov-Ogievskiy wrote: Good idea. But it would be tricky thing to maintain

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On 02/28/2018 02:26 PM, Eric Blake wrote: Okay, I've gone ahead and reverted the renumbering; NBD_INFO_BLOCK_SIZE is back to 5 It helps if I don't copy-and-paste the wrong thing. NBD_INFO_BLOCK_SIZE remains 3 (as it has always been), NBD_REPLY_TYPE_BLOCK_STATUS is reverted back to 5

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On 02/28/2018 07:08 AM, Wouter Verhelst wrote: Or, we can revert the change in commit 56c77720, and keep NBD_REPLY_TYPE_BLOCK_STATUS at 5 (it leaves a hole in the NBD_REPLY_TYPE numbering, where 3 and 4 might be filled in by other future extensions, or permanently skipped). This works IF there

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Hi, Sorry, I forgot to reply to this earlier. On Fri, Feb 16, 2018 at 10:10:59AM -0600, Eric Blake wrote: > On 02/16/2018 07:53 AM, Vladimir Sementsov-Ogievskiy wrote: > > Good idea. But it would be tricky thing to maintain backward > > compatibility with published versions of virtuozzo product.

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On 02/16/2018 07:53 AM, Vladimir Sementsov-Ogievskiy wrote: Good idea. But it would be tricky thing to maintain backward compatibility with published versions of virtuozzo product. And finally our implementation would be more complex because of this simplification. Hm. Finally, you

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

16.02.2018 15:35, Eric Blake wrote: Reviving an old thread, to bring up questions based on a new push to implement this extension in qemu. On 12/14/2016 09:08 AM, Alex Bligh wrote: * Change NBD_OPT_LIST_METADATA etc. to explicitly send a list of queries    and add a count of queries so we

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Reviving an old thread, to bring up questions based on a new push to implement this extension in qemu. On 12/14/2016 09:08 AM, Alex Bligh wrote: * Change NBD_OPT_LIST_METADATA etc. to explicitly send a list of queries and add a count of queries so we can extend the command later (rather

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Fri, Jan 20, 2017 at 01:35:10PM -0600, Eric Blake wrote: > On 01/20/2017 12:00 PM, Alex Bligh wrote: > > > >> On 20 Jan 2017, at 17:04, Vladimir Sementsov-Ogievskiy > >> wrote: > >> > >> About extents: is 32bit length enough? We will have to send 4096 for empty >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

29.12.2016 19:08, Alex Bligh wrote: Vladimir, On 26 Dec 2016, at 15:57, Vladimir Sementsov-Ogievskiy wrote: OK, so first of all, one of the changes I made earlier was that now each of the commands carries a list of queries, the way you list everything is not

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

29.12.2016 19:04, Alex Bligh wrote: On 28 Dec 2016, at 00:18, Wouter Verhelst wrote: On Mon, Dec 26, 2016 at 05:52:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: Shouldn't we add some flags to REP_META_CONTEXT, for client to be insure, is returned string a direct context name

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Vladimir, > On 26 Dec 2016, at 15:57, Vladimir Sementsov-Ogievskiy > wrote: > >> OK, so first of all, one of the changes I made earlier was that now >> each of the commands carries a list of queries, the way you list >> everything is not 'having a query that doesn't

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 28 Dec 2016, at 00:18, Wouter Verhelst wrote: > > On Mon, Dec 26, 2016 at 05:52:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: >> Shouldn't we add some flags to REP_META_CONTEXT, for client to be insure, is >> returned string a direct context name or some kind of wildcard?

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Hi Vladimir, On Mon, Dec 26, 2016 at 05:52:54PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Shouldn't we add some flags to REP_META_CONTEXT, for client to be insure, is > returned string a direct context name or some kind of wildcard? Just a flags > field, with one flag defined for now:

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

14.12.2016 22:01, Alex Bligh wrote: Wouter, (Our mails crossed and I've actually pushed something, but no matter) On 14 Dec 2016, at 18:49, Wouter Verhelst wrote: What I was trying to say is that I think the result to _LIST_ with no queries should return all information the

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 17 Dec 2016, at 08:34, Wouter Verhelst wrote: > > I've therefore removed that restriction as well as the "255 bytes max" > one that you added, since I don't think they make much sense. That > doesn't mean I can't be convinced otherwise by good arguments, but > they'd have to

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Fri, Dec 16, 2016 at 04:25:27PM +, Alex Bligh wrote: > > > On 16 Dec 2016, at 15:52, Wouter Verhelst wrote: > > > > On Thu, Dec 15, 2016 at 05:34:48PM +, Alex Bligh wrote: > >> > >>> On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: > >>> > Because

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 16 Dec 2016, at 15:52, Wouter Verhelst wrote: > > On Thu, Dec 15, 2016 at 05:34:48PM +, Alex Bligh wrote: >> >>> On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: >>> Because the namespaces and leaf-names are already restricted to non-whitespace

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Thu, Dec 15, 2016 at 05:34:48PM +, Alex Bligh wrote: > > > On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: > > > >> Because the namespaces and leaf-names are already restricted to > >> non-whitespace characters. I thought having tabs, line feeds, > >> returns, em-space,

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: > >> Because the namespaces and leaf-names are already restricted to >> non-whitespace characters. I thought having tabs, line feeds, >> returns, em-space, en-space etc. was not particularly useful. >> I could be persuaded to

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Thu, Dec 15, 2016 at 04:32:23PM +, Alex Bligh wrote: > Wouter, > > > This reads a bit awkward. I would do: > > > > s/save that:/except as explained below/ > > Possibly a British English thing. Will fix. It's mostly that the "save that:" suggests to me that the exception follows

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Wouter, > This reads a bit awkward. I would do: > > s/save that:/except as explained below/ Possibly a British English thing. Will fix. >>If one or more queries are sent, then the server MUST return >>those metadata contexts that are available to the client to >>select on the given

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Hi Alex, On Thu, Dec 15, 2016 at 10:04:05AM +, Alex Bligh wrote: > > > On 14 Dec 2016, at 20:18, Wouter Verhelst wrote: > > > >> +* the server MAY return a context consisting of a namespace and > >> + a colon only (i.e. omitting the leaf-name) to indicate that > >> +

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 14 Dec 2016, at 20:18, Wouter Verhelst wrote: > >> +* the server MAY return a context consisting of a namespace and >> + a colon only (i.e. omitting the leaf-name) to indicate that >> + the namespace contains a large number of possible contexts >> + within

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On 12/14/2016 12:09 PM, Wouter Verhelst wrote: > On Wed, Dec 14, 2016 at 03:08:40PM +, Alex Bligh wrote: >> (NB: I've already applied this and pushed it) > > Thanks. > >> * Change NBD_OPT_LIST_METADATA etc. to explicitly send a list of queries >> and add a count of queries so we can

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Wed, Dec 14, 2016 at 06:51:48PM +, Alex Bligh wrote: > > > On 14 Dec 2016, at 18:18, Alex Bligh wrote: > > > > Let me have a go at a change. > > OK I've pushed a change. I reordered a few bits (to put the > base:allocation next to the stuff that talks about metadata >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Wed, Dec 14, 2016 at 07:01:15PM +, Alex Bligh wrote: > Wouter, > > (Our mails crossed and I've actually pushed something, but no matter) > > > On 14 Dec 2016, at 18:49, Wouter Verhelst wrote: > > > > What I was trying to say is that I think the result to _LIST_ with no > >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Wouter, (Our mails crossed and I've actually pushed something, but no matter) > On 14 Dec 2016, at 18:49, Wouter Verhelst wrote: > > What I was trying to say is that I think the result to _LIST_ with no > queries should return all information the client needs to theoretically >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 14 Dec 2016, at 18:18, Alex Bligh wrote: > > Let me have a go at a change. OK I've pushed a change. I reordered a few bits (to put the base:allocation next to the stuff that talks about metadata queries at the start), but the main change is below. -- Alex Bligh @@

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Wed, Dec 14, 2016 at 06:18:58PM +, Alex Bligh wrote: > > > On 14 Dec 2016, at 18:13, Wouter Verhelst wrote: > > > > Instead, I would suggest that the spec leave it up to the namespace spec > > to define what gets listed when. The namespace should still give some > >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

> On 14 Dec 2016, at 18:13, Wouter Verhelst wrote: > > Instead, I would suggest that the spec leave it up to the namespace spec > to define what gets listed when. The namespace should still give some > indication that a particular *type* of context is available, though; > e.g.,

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Wed, Dec 14, 2016 at 08:55:56PM +0300, Vladimir Sementsov-Ogievskiy wrote: > 14.12.2016 20:36, Alex Bligh wrote: > >> On 14 Dec 2016, at 17:05, Vladimir Sementsov-Ogievskiy > >> wrote: > >>> However, this raises another question. Wouter deliberately made the > >>>

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

Wouter, > Right. I think we're getting close to a good spec now, for this thing. > > One thing I've been thinking about that we might want to add: > > There may be cases where a server, in performing the required calls to > be able to handle a BLOCK_STATUS request, will end up with more >

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

14.12.2016 20:09, Wouter Verhelst wrote: On Wed, Dec 14, 2016 at 03:08:40PM +, Alex Bligh wrote: (NB: I've already applied this and pushed it) Thanks. * Change NBD_OPT_LIST_METADATA etc. to explicitly send a list of queries and add a count of queries so we can extend the command later

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

On Wed, Dec 14, 2016 at 03:08:40PM +, Alex Bligh wrote: > (NB: I've already applied this and pushed it) Thanks. > * Change NBD_OPT_LIST_METADATA etc. to explicitly send a list of queries > and add a count of queries so we can extend the command later (rather than > rely on the length of