Re: [Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-26 Thread Laurent Vivier
ping Le dimanche 20 janvier 2013 à 00:26 +0100, Laurent Vivier a écrit : > Le lundi 07 janvier 2013 à 21:46 +, Peter Maydell a écrit : > > On 7 January 2013 21:40, Laurent Vivier wrote: > > > According to man reboot(2), the 4th argument is only used with > > > LINUX_REBOOT_CMD_RESTART2. In ot

Re: [Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-19 Thread Laurent Vivier
Le lundi 07 janvier 2013 à 21:46 +, Peter Maydell a écrit : > On 7 January 2013 21:40, Laurent Vivier wrote: > > According to man reboot(2), the 4th argument is only used with > > LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert > > the value can generate EFAULT. > > > > Signed-off

Re: [Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-07 Thread Peter Maydell
On 7 January 2013 21:40, Laurent Vivier wrote: > According to man reboot(2), the 4th argument is only used with > LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert > the value can generate EFAULT. > > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-07 Thread Laurent Vivier
According to man reboot(2), the 4th argument is only used with LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert the value can generate EFAULT. Signed-off-by: Laurent Vivier --- v2: Set arg4 to NULL when arg3 != LINUX_REBOOT_CMD_RESTART2 use get_errno() check patch checkpatch.p