Re: [Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-12 Thread Alon Levy
On Tue, Jan 10, 2012 at 08:13:00PM +0100, andrzej zaborowski wrote: On 10 January 2012 09:44, Alon Levy al...@redhat.com wrote: All but the last are assigned but unused variables, and an always true comparison, but the last looks like a logic error - decode not returning the actual return

Re: [Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-12 Thread andrzej zaborowski
On 12 January 2012 11:42, Alon Levy al...@redhat.com wrote: Don't mind at all! But for some reason this email and the other one I send before it to you and to the qemu-devel list didn't reach the list. If you saw this email is it too much to assume you saw the other one as well? Thanks.

[Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-11 Thread Alon Levy
All but the last are assigned but unused variables, and an always true comparison, but the last looks like a logic error - decode not returning the actual return value for the last call in the buffer (vmgl-exec.c). --- gl/gloffscreen-xcomposite.c |4 +--- gl/vmgl-exec.c | 10

Re: [Qemu-devel] [PATCH] (dont commit) virtio-gl-fixes for build on F17

2012-01-11 Thread andrzej zaborowski
On 10 January 2012 09:44, Alon Levy al...@redhat.com wrote: All but the last are assigned but unused variables, and an always true comparison, but the last looks like a logic error - decode not returning the actual return value for the last call in the buffer (vmgl-exec.c). ---