Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Anthony Liguori
On 07/27/2011 04:21 PM, Stefan Weil wrote: NDEBUG is normally set automatically for production code, and it disables assertions which is not always good. Assertions are useful even in production code unless you are sure that the code is bug free or the assertions cost to much resources - either

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Anthony Liguori
On 07/27/2011 04:12 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 11:48 PM, Anthony Liguori wrote: On 07/27/2011 03:43 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: This allows GSources to be used to register callback events in QEMU. This is useful as it

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Stefan Weil
Am 27.07.2011 23:12, schrieb Blue Swirl: On Wed, Jul 27, 2011 at 11:48 PM, Anthony Liguori wrote: On 07/27/2011 03:43 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: This allows GSources to be used to register callback events in QEMU. This i

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Blue Swirl
On Wed, Jul 27, 2011 at 11:48 PM, Anthony Liguori wrote: > On 07/27/2011 03:43 PM, Blue Swirl wrote: >> >> On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori >>  wrote: >>> >>> This allows GSources to be used to register callback events in QEMU. >>>  This is >>> useful as it allows us to take greate

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Anthony Liguori
On 07/27/2011 03:43 PM, Blue Swirl wrote: On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: This allows GSources to be used to register callback events in QEMU. This is useful as it allows us to take greater advantage of glib and also because it allows us to write code that is more easil

Re: [Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-27 Thread Blue Swirl
On Wed, Jul 27, 2011 at 3:06 AM, Anthony Liguori wrote: > This allows GSources to be used to register callback events in QEMU.  This is > useful as it allows us to take greater advantage of glib and also because it > allows us to write code that is more easily testable outside of QEMU since we > c

[Qemu-devel] [PATCH] [RFC] Add glib support to main loop

2011-07-26 Thread Anthony Liguori
This allows GSources to be used to register callback events in QEMU. This is useful as it allows us to take greater advantage of glib and also because it allows us to write code that is more easily testable outside of QEMU since we can make use of glib's main loop in unit tests. All new code shou