Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread Greg Kurz
On Tue, 13 Mar 2018 15:52:41 + Stefan Hajnoczi wrote: > On Tue, Mar 13, 2018 at 3:25 PM, nee wrote: > > On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > >> On Mon, 12 Mar 2018 13:08:29 + > >> Daniel P. Berrangé

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread Stefan Hajnoczi
On Tue, Mar 13, 2018 at 3:25 PM, nee wrote: > On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: >> On Mon, 12 Mar 2018 13:08:29 + >> Daniel P. Berrangé wrote: >> >>> On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: >>> >

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-13 Thread nee
On Mon, Mar 12, 2018 at 1:21 PM, Greg Kurz wrote: > On Mon, 12 Mar 2018 13:08:29 + > Daniel P. Berrangé wrote: > >> On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: >> > On Mon, 12 Mar 2018 07:12:52 -0500 >> > Eric Blake

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Greg Kurz
On Mon, 12 Mar 2018 13:08:29 + Daniel P. Berrangé wrote: > On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: > > On Mon, 12 Mar 2018 07:12:52 -0500 > > Eric Blake wrote: > > > > > On 03/11/2018 03:12 PM, Nia Alarie wrote: > > > >

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Greg Kurz
On Mon, 12 Mar 2018 10:01:46 +0100 Greg Kurz wrote: > On Sun, 11 Mar 2018 20:12:39 + > Nia Alarie wrote: > > > Signed-off-by: Nia Alarie > > --- > > Applied, thanks. > Following Eric's suggestion in another mail, let's give

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Daniel P . Berrangé
On Mon, Mar 12, 2018 at 02:02:29PM +0100, Greg Kurz wrote: > On Mon, 12 Mar 2018 07:12:52 -0500 > Eric Blake wrote: > > > On 03/11/2018 03:12 PM, Nia Alarie wrote: > > > Signed-off-by: Nia Alarie > > > --- > > > hw/9pfs/9p.c | 12 ++-- > > > 1

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Greg Kurz
On Mon, 12 Mar 2018 07:12:52 -0500 Eric Blake wrote: > On 03/11/2018 03:12 PM, Nia Alarie wrote: > > Signed-off-by: Nia Alarie > > --- > > hw/9pfs/9p.c | 12 ++-- > > 1 file changed, 10 insertions(+), 2 deletions(-) > > > > > } else

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Eric Blake
On 03/11/2018 03:12 PM, Nia Alarie wrote: Signed-off-by: Nia Alarie --- hw/9pfs/9p.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) } else if (perm & P9_STAT_MODE_LINK) { -int32_t ofid = atoi(extension.data); -V9fsFidState

Re: [Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-12 Thread Greg Kurz
On Sun, 11 Mar 2018 20:12:39 + Nia Alarie wrote: > Signed-off-by: Nia Alarie > --- Applied, thanks. > hw/9pfs/9p.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > index

[Qemu-devel] [PATCH] 9p: Convert use of atoi to qemu_strtol to allow error checking

2018-03-11 Thread Nia Alarie
Signed-off-by: Nia Alarie --- hw/9pfs/9p.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 48fa48e720..64f3bb976c 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -15,6 +15,7 @@ #include #include