Re: [Qemu-devel] [PATCH] 9pfs: fix error path in pdu_submit()

2017-12-20 Thread Eric Blake
On 12/15/2017 10:42 AM, Greg Kurz wrote: If we receive an unsupported request id, we first decide to return -ENOTSUPP to the client, but since the request id causes is_read_only_op() to return false, we change the error to be -EROFS if the fsdev is read-only. This doesn't make sense since we don'

[Qemu-devel] [PATCH] 9pfs: fix error path in pdu_submit()

2017-12-15 Thread Greg Kurz
If we receive an unsupported request id, we first decide to return -ENOTSUPP to the client, but since the request id causes is_read_only_op() to return false, we change the error to be -EROFS if the fsdev is read-only. This doesn't make sense since we don't know what the client asked for. This pat