Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

2017-01-24 Thread Greg Kurz
On Tue, 24 Jan 2017 14:24:23 -0800 (PST) Stefano Stabellini wrote: > On Tue, 24 Jan 2017, Greg Kurz wrote: > > On Mon, 23 Jan 2017 12:20:57 -0800 (PST) > > Stefano Stabellini wrote: > > > > > On Sat, 21 Jan 2017, Greg Kurz wrote: > > > > The

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

2017-01-24 Thread Stefano Stabellini
On Tue, 24 Jan 2017, Greg Kurz wrote: > On Mon, 23 Jan 2017 12:20:57 -0800 (PST) > Stefano Stabellini wrote: > > > On Sat, 21 Jan 2017, Greg Kurz wrote: > > > The current code tries to copy `read_count' bytes starting at offset > > > `offset' from a `read_count`-sized

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

2017-01-23 Thread Greg Kurz
On Mon, 23 Jan 2017 12:20:57 -0800 (PST) Stefano Stabellini wrote: > On Sat, 21 Jan 2017, Greg Kurz wrote: > > The current code tries to copy `read_count' bytes starting at offset > > `offset' from a `read_count`-sized iovec. This causes v9fs_pack() to > > fail with

Re: [Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

2017-01-23 Thread Stefano Stabellini
On Sat, 21 Jan 2017, Greg Kurz wrote: > The current code tries to copy `read_count' bytes starting at offset > `offset' from a `read_count`-sized iovec. This causes v9fs_pack() to > fail with ENOBUFS. > > Since the PDU iovec is already partially filled with `offset' bytes, > let's skip them when

[Qemu-devel] [PATCH] 9pfs: fix offset error in v9fs_xattr_read()

2017-01-21 Thread Greg Kurz
The current code tries to copy `read_count' bytes starting at offset `offset' from a `read_count`-sized iovec. This causes v9fs_pack() to fail with ENOBUFS. Since the PDU iovec is already partially filled with `offset' bytes, let's skip them when creating `qiov_full' and have v9fs_pack() to copy