[Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Dmitry Koshelev
Fixes two trivial indices errors. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com --- hw/arm_gic.c | 12 ++-- target-arm/machine.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 8286a28..ba05131 100644 ---

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Stefan Hajnoczi
On Fri, Oct 14, 2011 at 05:25:29PM +0400, Dmitry Koshelev wrote: Fixes two trivial indices errors. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com --- hw/arm_gic.c | 12 ++-- target-arm/machine.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) Not

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Andreas Färber
Am 14.10.2011 15:25, schrieb Dmitry Koshelev: Fixes two trivial indices errors. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com --- hw/arm_gic.c | 12 ++-- target-arm/machine.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Paul Brook
Fixes two trivial indices errors. No. You're doing two much in a single patch. While both happen to be bug in the save/restore code involving arrays, these are not two instances of the same bug. The justification for each change is completely different. Even if each change was obviously

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Dmitry Koshelev
On Fri, Oct 14, 2011 at 7:04 PM, Paul Brook p...@codesourcery.com wrote: Fixes two trivial indices errors. No. You're doing two much in a single patch. While both happen to be bug in the save/restore code involving arrays, these are not two instances of the same bug.  The justification for