Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-08 Thread Dr. David Alan Gilbert
* Stefan Fritsch (s...@sfritsch.de) wrote: > Sending a break on a serial console can be useful for debugging the > guest. But not all chardev backends support sending breaks (only telnet > and mux do). The chardev-send-break command allows to send a break even > if using other backends. > > Signed

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-07 Thread Paolo Bonzini
- Original Message - > From: "Markus Armbruster" > To: "Paolo Bonzini" > Cc: "Stefan Fritsch" , qemu-devel@nongnu.org, "Dr. David > Alan Gilbert" , > "Marc-André Lureau" > Sent: Wednesday, June 7, 2017 9:06:53 A

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-07 Thread Markus Armbruster
Paolo Bonzini writes: >> >> Is there an obvious test that we can enhance to add coverage of the new >> >> QMP command? >> > >> > You could have a new test covering hw/char/serial.c, but I wouldn't let >> > that hold the patch. >> >> Holding patches is pretty much the only leverage I have to get

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-06 Thread Paolo Bonzini
> >> Is there an obvious test that we can enhance to add coverage of the new > >> QMP command? > > > > You could have a new test covering hw/char/serial.c, but I wouldn't let > > that hold the patch. > > Holding patches is pretty much the only leverage I have to get tests for > new stuff :) > > A

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-06 Thread Stefan Fritsch
On Tue, 6 Jun 2017, Markus Armbruster wrote: > >> Is there an obvious test that we can enhance to add coverage of the new > >> QMP command? > > > > You could have a new test covering hw/char/serial.c, but I wouldn't let > > that hold the patch. > > Holding patches is pretty much the only leverage

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-06 Thread Markus Armbruster
Paolo Bonzini writes: > On 05/06/2017 14:24, Eric Blake wrote: >> On 06/05/2017 03:52 AM, Stefan Fritsch wrote: >>> Sending a break on a serial console can be useful for debugging the >>> guest. But not all chardev backends support sending breaks (only telnet >>> and mux do). The chardev-send-bre

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-06 Thread Paolo Bonzini
On 05/06/2017 14:24, Eric Blake wrote: > On 06/05/2017 03:52 AM, Stefan Fritsch wrote: >> Sending a break on a serial console can be useful for debugging the >> guest. But not all chardev backends support sending breaks (only telnet >> and mux do). The chardev-send-break command allows to send a

Re: [Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-05 Thread Eric Blake
On 06/05/2017 03:52 AM, Stefan Fritsch wrote: > Sending a break on a serial console can be useful for debugging the > guest. But not all chardev backends support sending breaks (only telnet > and mux do). The chardev-send-break command allows to send a break even > if using other backends. > > Sig

[Qemu-devel] [PATCH] Add chardev-send-break monitor command

2017-06-05 Thread Stefan Fritsch
Sending a break on a serial console can be useful for debugging the guest. But not all chardev backends support sending breaks (only telnet and mux do). The chardev-send-break command allows to send a break even if using other backends. Signed-off-by: Stefan Fritsch --- chardev/char.c | 12 +++