Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-19 Thread Eduardo Habkost
Ping? Who is willing to apply this? On Sun, Feb 09, 2014 at 07:03:01AM -0200, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > > Signed-off-by: Eduardo Habkost > --- > CODING_STYLE | 7 +++ > 1 file changed

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-14 Thread Stefan Hajnoczi
On Sun, Feb 09, 2014 at 07:03:01AM -0200, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > > Signed-off-by: Eduardo Habkost > --- > CODING_STYLE | 7 +++ > 1 file changed, 7 insertions(+) I think C99 mixed

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-10 Thread Eduardo Habkost
On Mon, Feb 10, 2014 at 09:33:06AM +0800, Fam Zheng wrote: > On Sun, 02/09 07:03, Eduardo Habkost wrote: > > We had an unwritten rule about declarations having to be at beginning of > > blocks. Make it a written rule. > > > > Signed-off-by: Eduardo Habkost > > --- > > CODING_STYLE | 7 +++ >

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-09 Thread Stefan Weil
Am 10.02.2014 02:33, schrieb Fam Zheng: > On Sun, 02/09 07:03, Eduardo Habkost wrote: >> We had an unwritten rule about declarations having to be at beginning of >> blocks. Make it a written rule. >> >> Signed-off-by: Eduardo Habkost >> --- >> CODING_STYLE | 7 +++ >> 1 file changed, 7 insert

Re: [Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-09 Thread Fam Zheng
On Sun, 02/09 07:03, Eduardo Habkost wrote: > We had an unwritten rule about declarations having to be at beginning of > blocks. Make it a written rule. > > Signed-off-by: Eduardo Habkost > --- > CODING_STYLE | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/CODING_STYLE b/CODING_

[Qemu-devel] [PATCH] CODING_STYLE: Section about mixed declarations

2014-02-09 Thread Eduardo Habkost
We had an unwritten rule about declarations having to be at beginning of blocks. Make it a written rule. Signed-off-by: Eduardo Habkost --- CODING_STYLE | 7 +++ 1 file changed, 7 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index dcbce28..f6eb319 100644 --- a/CODING_STYLE +++ b/C