Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Luiz Capitulino
On Tue, 14 Sep 2010 10:59:56 -0500 Adam Litke wrote: > On Tue, 2010-09-14 at 12:46 -0300, Luiz Capitulino wrote: > > On Tue, 14 Sep 2010 12:42:00 -0300 > > Eduardo Habkost wrote: > > > > > I keep my suggestion: if all we need is to change the way "info balloon" > > > behaves, then we can simply

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Adam Litke
Ok, I can see how this will work better for the migration case. Acked-by: Adam Litke On Tue, 2010-09-14 at 11:09 -0300, Eduardo Habkost wrote: > This field is guest-visible, won't this cause problems on migration? > > Isn't it better to disable it on the "info balloon" side, so the guest > know

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Adam Litke
On Tue, 2010-09-14 at 12:46 -0300, Luiz Capitulino wrote: > On Tue, 14 Sep 2010 12:42:00 -0300 > Eduardo Habkost wrote: > > > I keep my suggestion: if all we need is to change the way "info balloon" > > behaves, then we can simply change the "info balloon" behavior, intead > > of changing the gue

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Luiz Capitulino
On Tue, 14 Sep 2010 12:42:00 -0300 Eduardo Habkost wrote: > I keep my suggestion: if all we need is to change the way "info balloon" > behaves, then we can simply change the "info balloon" behavior, intead > of changing the guest-visible machine model. Adam, what problems do you see with this so

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Eduardo Habkost
On Tue, Sep 14, 2010 at 11:41:55AM -0300, Eduardo Habkost wrote: > On Tue, Sep 14, 2010 at 09:24:11AM -0500, Adam Litke wrote: > > On Tue, 2010-09-14 at 11:09 -0300, Eduardo Habkost wrote: > > > On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote: > [...] > > > > static uint32_t virtio_ball

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Eduardo Habkost
On Tue, Sep 14, 2010 at 09:24:11AM -0500, Adam Litke wrote: > On Tue, 2010-09-14 at 11:09 -0300, Eduardo Habkost wrote: > > On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote: [...] > > > static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t > > > f) > > > { > > > -

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Adam Litke
On Tue, 2010-09-14 at 11:09 -0300, Eduardo Habkost wrote: > On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote: > > The addition of memory stats reporting to the virtio balloon causes > > the 'info balloon' command to become asynchronous. This is a regression > > because in some cases it c

Re: [Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-14 Thread Eduardo Habkost
On Wed, Sep 08, 2010 at 09:21:16AM -0500, Adam Litke wrote: > The addition of memory stats reporting to the virtio balloon causes > the 'info balloon' command to become asynchronous. This is a regression > because in some cases it can hang the user monitor. > > Disable this feature until a better

[Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-09-08 Thread Adam Litke
The addition of memory stats reporting to the virtio balloon causes the 'info balloon' command to become asynchronous. This is a regression because in some cases it can hang the user monitor. Disable this feature until a better interface for asynchronous commands can be worked out. Signed-off-by

[Qemu-devel] [PATCH] Disable virtio-balloon memory stats interface

2010-08-30 Thread Adam Litke
Just got back from vacation and saw this thread. I agree with Anthony that the best thing to do is disable the memory stats interface for 0.13. We need to fix the underlying problems in qemu with respect to asynchronous commands first, then we can look at re-enabling the feature. The virtio feat