Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives

2010-07-21 Thread Jes Sorensen
On 07/20/10 19:19, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 07/20/10 18:35, David S. Ahern wrote: >>> On 07/20/10 10:09, jes.soren...@redhat.com wrote: >>> If a cdrom is added via the monitor this would abruptly terminate the VM >>> - which is not good. >> >> True, but this would o

Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives

2010-07-20 Thread Markus Armbruster
Jes Sorensen writes: > On 07/20/10 18:35, David S. Ahern wrote: >> On 07/20/10 10:09, jes.soren...@redhat.com wrote: >>> diff --git a/block/raw-posix.c b/block/raw-posix.c >>> index 291699f..1b840c4 100644 >>> --- a/block/raw-posix.c >>> +++ b/block/raw-posix.c >>> @@ -1139,6 +1139,11 @@ static i

Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives

2010-07-20 Thread Jes Sorensen
On 07/20/10 18:35, David S. Ahern wrote: > On 07/20/10 10:09, jes.soren...@redhat.com wrote: >> diff --git a/block/raw-posix.c b/block/raw-posix.c >> index 291699f..1b840c4 100644 >> --- a/block/raw-posix.c >> +++ b/block/raw-posix.c >> @@ -1139,6 +1139,11 @@ static int cdrom_open(BlockDriverState

Re: [Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives

2010-07-20 Thread David S. Ahern
On 07/20/10 10:09, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > O_DIRECT (cache=none) requires sector alignment, however the physical > sector size of CDROM/DVD drives is 2048, as opposed to most disk > devices which use 512. QEMU is hard coding 512 all over the place, so > allowing

[Qemu-devel] [PATCH] Error on O_DIRECT for physical CDROM/DVD drives

2010-07-20 Thread Jes . Sorensen
From: Jes Sorensen O_DIRECT (cache=none) requires sector alignment, however the physical sector size of CDROM/DVD drives is 2048, as opposed to most disk devices which use 512. QEMU is hard coding 512 all over the place, so allowing O_DIRECT for CDROM/DVD devices does not work. Exit with an error