Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-29 Thread Andrey Shinkevich
On 27/08/2019 18:59, Alex Bennée wrote: > > Andrey Shinkevich writes: > >> On 13/08/2019 15:21, Alex Bennée wrote: >>> >>> Andrey Shinkevich writes: >>> PINGING... >>> >>> Sorry about the delay. I did attempt see if the existing code threw up >>> any errors when built with clang's undefi

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-27 Thread Alex Bennée
Andrey Shinkevich writes: > On 13/08/2019 15:21, Alex Bennée wrote: >> >> Andrey Shinkevich writes: >> >>> PINGING... >> >> Sorry about the delay. I did attempt see if the existing code threw up >> any errors when built with clang's undefined sanitizer. I think this is >> because xPtr->exp wil

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-27 Thread Andrey Shinkevich
I just worry about this simple patch to be lost because I got some mess with it in my Thunderbird email threads. Andrey On 20/08/2019 20:01, Andrey Shinkevich wrote: > On 13/08/2019 15:21, Alex Bennée wrote: >> >> Andrey Shinkevich writes: >> >>> PINGING... >> >> Sorry about the delay. I did at

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-20 Thread Andrey Shinkevich
On 13/08/2019 15:21, Alex Bennée wrote: > > Andrey Shinkevich writes: > >> PINGING... > > Sorry about the delay. I did attempt see if the existing code threw up > any errors when built with clang's undefined sanitizer. I think this is > because xPtr->exp will only get read if none of the xPtr->

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-20 Thread Peter Maydell
On Tue, 20 Aug 2019 at 16:18, Andrey Shinkevich wrote: > > PINGING... Hi -- Alex asked you a question on the 13th when you last pinged this patch, which I don't think you've replied to yet (or if you did then my mail client has filed it somewhere unhelpful). thanks -- PMM

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-20 Thread Andrey Shinkevich
PINGING... On 30/07/2019 13:13, Andrey Shinkevich wrote: > Not all the paths in the functions, such as f16ToFloatX(), initialize > the member 'exp' of the structure floatX. > > Signed-off-by: Andrey Shinkevich > --- > source/slowfloat.c | 4 > 1 file changed, 4 insertions(+) > > diff --

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-13 Thread Alex Bennée
Andrey Shinkevich writes: > PINGING... Sorry about the delay. I did attempt see if the existing code threw up any errors when built with clang's undefined sanitizer. I think this is because xPtr->exp will only get read if none of the xPtr->isFOO returns false. In all those cases xPtr->exp is s

Re: [Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-08-13 Thread Andrey Shinkevich
PINGING... On 30/07/2019 13:13, Andrey Shinkevich wrote: > Not all the paths in the functions, such as f16ToFloatX(), initialize > the member 'exp' of the structure floatX. > > Signed-off-by: Andrey Shinkevich > --- > source/slowfloat.c | 4 > 1 file changed, 4 insertions(+) > > diff --

[Qemu-devel] [PATCH] Fix: fp-test uninitialized member floatX::exp

2019-07-30 Thread Andrey Shinkevich
Not all the paths in the functions, such as f16ToFloatX(), initialize the member 'exp' of the structure floatX. Signed-off-by: Andrey Shinkevich --- source/slowfloat.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/fp/berkeley-testfloat-3/source/slowfloat.c b/tests/fp/berkeley-te