Re: [Qemu-devel] [PATCH] Fix SWI (SVC) instruction in THUMB.

2012-12-25 Thread Peter Maydell
On 25 December 2012 23:00, Peter Maydell wrote: > On 25 December 2012 14:21, Alex Rozenman wrote: >> target-arm/helper.c (do_interrupt_v7m): When do_interrupt_v7m is called, >> PC is already points to a correct instruction (after the SVC one). Don't >> modify the PC here. PS: this commit message

Re: [Qemu-devel] [PATCH] Fix SWI (SVC) instruction in THUMB.

2012-12-25 Thread Peter Maydell
On 25 December 2012 14:21, Alex Rozenman wrote: > target-arm/helper.c (do_interrupt_v7m): When do_interrupt_v7m is called, > PC is already points to a correct instruction (after the SVC one). Don't > modify the PC here. Looks plausible, but (a) your commit message doesn't make it clear that this

[Qemu-devel] [PATCH] Fix SWI (SVC) instruction in THUMB.

2012-12-25 Thread Alex Rozenman
target-arm/helper.c (do_interrupt_v7m): When do_interrupt_v7m is called, PC is already points to a correct instruction (after the SVC one). Don't modify the PC here. Signed-off-by: Alex Rozenman --- target-arm/helper.c |1 - 1 file changed, 1 deletion(-) diff --git a/target-arm/helper.c b/t