Re: [Qemu-devel] [PATCH] Fix bug in translation of REVSH

2010-12-27 Thread Aurelien Jarno
On Mon, Oct 18, 2010 at 02:49:36PM +0200, Johan Bengtsson wrote: > The translation of REVSH shifted the low byte 8 steps left before performing > an 8-bit sign extend, causing this part of the expression to alwas be 0. > The fix for this is either to extend before shifting or switch to a 16-bit > e

[Qemu-devel] [PATCH] Fix bug in translation of REVSH

2010-10-18 Thread Johan Bengtsson
The translation of REVSH shifted the low byte 8 steps left before performing an 8-bit sign extend, causing this part of the expression to alwas be 0. The fix for this is either to extend before shifting or switch to a 16-bit extend. I choose the former. Signed-off-by: Johan Bengtsson --- target-