Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-28 Thread Laurent Desnogues
Johannes Schindelin a écrit : And what system did you encounter this behaviour on? Do a: grep -wr DEFAULT_SIGNED_CHAR gcc/config in a gcc source tree and you will get a list for gcc targets :) Laurent ___ Qemu-devel

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-28 Thread Martin Guy
gcc on ARM systems default to unsigned. The C standard specifically states that char is either signed or unsigned at the whim of the implementor Or, more to the point, at the behest of the machine architecture. Having to generate code to sign-extend the hard way every time you do char-integer

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-28 Thread Rob Landley
On Friday 27 October 2006 7:09 pm, Paul Brook wrote: It has been a really long time I have been working on a broken system that did not default to signed. The only thing that is broken is your knowlege of C. Okay. And what system did you encounter this behaviour on? Common

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-28 Thread Rob Landley
On Saturday 28 October 2006 6:46 am, Martin Guy wrote: gcc on ARM systems default to unsigned. The C standard specifically states that char is either signed or unsigned at the whim of the implementor Or, more to the point, at the behest of the machine architecture. Having to generate

[Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread Andreas Schwab
If you want to put a negative number in a char you must use a signed char. Andreas. Index: fpu/softfloat-native.c === RCS file: /sources/qemu/qemu/fpu/softfloat-native.c,v retrieving revision 1.5 diff -u -a -p -r1.5

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread Johannes Schindelin
Hi, On Fri, 27 Oct 2006, Andreas Schwab wrote: If you want to put a negative number in a char you must use a signed char. It has been a really long time I have been working on a broken system that did not default to signed. Just out of curiosity: what system did you see the breakage on?

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread andrzej zaborowski
On 27/10/06, Johannes Schindelin [EMAIL PROTECTED] wrote: On Fri, 27 Oct 2006, Andreas Schwab wrote: It has been a really long time I have been working on a broken system that did not default to signed. Just out of curiosity: what system did you see the breakage on? AFAIK, it's not a broken

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread Andreas Schwab
Johannes Schindelin [EMAIL PROTECTED] writes: It has been a really long time I have been working on a broken system that did not default to signed. The only thing that is broken is your knowlege of C. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH,

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Andreas Schwab [EMAIL PROTECTED] writes: : Johannes Schindelin [EMAIL PROTECTED] writes: : : It has been a really long time I have been working on a broken system that : did not default to signed. : : The only thing that is broken is your knowlege of

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread Johannes Schindelin
Hi, On Fri, 27 Oct 2006, Andreas Schwab wrote: Johannes Schindelin [EMAIL PROTECTED] writes: It has been a really long time I have been working on a broken system that did not default to signed. The only thing that is broken is your knowlege of C. Okay. And what system did you

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread Paul Brook
It has been a really long time I have been working on a broken system that did not default to signed. The only thing that is broken is your knowlege of C. Okay. And what system did you encounter this behaviour on? Common arm, ppc, s390 and mips systems all have default char as

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Johannes Schindelin [EMAIL PROTECTED] writes: : Hi, : : On Fri, 27 Oct 2006, Andreas Schwab wrote: : : Johannes Schindelin [EMAIL PROTECTED] writes: : : It has been a really long time I have been working on a broken system that : did not default

Re: [Qemu-devel] [PATCH] Fix char signedness

2006-10-27 Thread Thiemo Seufer
Johannes Schindelin wrote: Hi, On Fri, 27 Oct 2006, Andreas Schwab wrote: Johannes Schindelin [EMAIL PROTECTED] writes: It has been a really long time I have been working on a broken system that did not default to signed. The only thing that is broken is your knowlege of