Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-18 Thread Gerd Hoffmann
On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote: > > This commit unconditionnally calls spice_server_set_sasl_appname() > > s/unconditionnally/unconditionally/ Fixed up, no need to resend. cheers, Gerd signature.asc Description: This is a digitally signed message part

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-18 Thread Christophe Fergeau
On Mon, Jan 18, 2016 at 11:11:42AM +0100, Gerd Hoffmann wrote: > On Fr, 2016-01-15 at 16:33 -0700, Eric Blake wrote: > > > This commit unconditionnally calls spice_server_set_sasl_appname() > > > > s/unconditionnally/unconditionally/ > > Fixed up, no need to resend. Thanks! Christophe

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-15 Thread Eric Blake
On 01/12/2016 07:08 AM, Christophe Fergeau wrote: > Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting > QEMU with SPICE but no SASL, and at the same time VNC with SASL, then > spice_server_init() will get called without a previous call to > spice_server_set_sasl_appname(),

Re: [Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-12 Thread Gerd Hoffmann
On Di, 2016-01-12 at 15:08 +0100, Christophe Fergeau wrote: > Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting > QEMU with SPICE but no SASL, and at the same time VNC with SASL, then > spice_server_init() will get called without a previous call to >

[Qemu-devel] [PATCH] Fix corner-case when using VNC+SASL+SPICE

2016-01-12 Thread Christophe Fergeau
Similarly to the commit 764eb39d1b6 fixing VNC+SASL+QXL, when starting QEMU with SPICE but no SASL, and at the same time VNC with SASL, then spice_server_init() will get called without a previous call to spice_server_set_sasl_appname(), which will cause cyrus-sasl to try to use