Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-11 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote: An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau chout...@adacore.com --- block/raw-win32.c | 17 ++--- 1 file

Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-11 Thread Kevin Wolf
Am 11.12.2012 10:21, schrieb Stefan Hajnoczi: On Mon, Dec 10, 2012 at 12:56:22PM +0100, Fabien Chouteau wrote: An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau chout...@adacore.com ---

Re: [Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-11 Thread Fabien Chouteau
On 12/11/2012 10:21 AM, Stefan Hajnoczi wrote: The fprintf() is kind of iffy but we only return -EIO so I guess it helps to print the full error. I add it because it took me a while to get to the actual error. Without it the error message is even more cryptic: qemu-system-ppc.exe: -hda

[Qemu-devel] [PATCH] Fix error code checking for SetFilePointer() call

2012-12-10 Thread Fabien Chouteau
An error has occurred if the return value is invalid_set_file_pointer and getlasterror doesn't return no_error. Signed-off-by: Fabien Chouteau chout...@adacore.com --- block/raw-win32.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/block/raw-win32.c