Re: [Qemu-devel] [PATCH] Fix float64_to_uint64

2013-10-16 Thread Peter Maydell
On 16 October 2013 15:19, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. This

Re: [Qemu-devel] [PATCH] Fix float64_to_uint64

2013-10-16 Thread Richard Henderson
On 10/16/2013 07:19 AM, Tom Musta wrote: > The comment preceding the float64_to_uint64 routine suggests that > the implementation is broken. And this is, indeed, the case. > > This patch properly implements the conversion of a 64-bit floating > point number to an unsigned, 64 bit integer. > > No

[Qemu-devel] [PATCH] Fix float64_to_uint64

2013-10-16 Thread Tom Musta
The comment preceding the float64_to_uint64 routine suggests that the implementation is broken. And this is, indeed, the case. This patch properly implements the conversion of a 64-bit floating point number to an unsigned, 64 bit integer. Note that the patch does not pass scripts/checkpatch.pl