Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-18 Thread Philippe Mathieu-Daudé
On 8/18/19 2:28 PM, Yuval Shaia wrote: > On Thu, Aug 15, 2019 at 02:12:44PM +0200, Stephen Kitt wrote: >> On Thu, 15 Aug 2019 13:57:05 +0300, Yuval Shaia >> wrote: >> >>> On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote: This was broken by the cherry-pick in 41dd30f. Fix by handli

Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-18 Thread Yuval Shaia
On Thu, Aug 15, 2019 at 02:12:44PM +0200, Stephen Kitt wrote: > On Thu, 15 Aug 2019 13:57:05 +0300, Yuval Shaia > wrote: > > > On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote: > > > This was broken by the cherry-pick in 41dd30f. Fix by handling errors > > > as in the rest of the func

Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-15 Thread Stephen Kitt
On Thu, 15 Aug 2019 13:57:05 +0300, Yuval Shaia wrote: > On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote: > > This was broken by the cherry-pick in 41dd30f. Fix by handling errors > > as in the rest of the function: "goto out" instead of "return rc". > > > > Signed-off-by: Stephen K

Re: [Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-15 Thread Yuval Shaia
On Sun, Aug 11, 2019 at 09:42:47PM +0200, Stephen Kitt wrote: > This was broken by the cherry-pick in 41dd30f. Fix by handling errors > as in the rest of the function: "goto out" instead of "return rc". > > Signed-off-by: Stephen Kitt > --- > hw/rdma/vmw/pvrdma_cmd.c | 2 +- > 1 file changed, 1

[Qemu-devel] [PATCH] Fix hw/rdma/vmw/pvrdma_cmd.c build

2019-08-11 Thread Stephen Kitt
This was broken by the cherry-pick in 41dd30f. Fix by handling errors as in the rest of the function: "goto out" instead of "return rc". Signed-off-by: Stephen Kitt --- hw/rdma/vmw/pvrdma_cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma