Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

On Thu, Sep 1, 2016 at 9:13 PM, Paolo Bonzini wrote: > On 01/09/2016 07:31, Ashijeet Acharya wrote: >> I am still waiting for review on this one. > > Hi, > > QEMU is in hard freeze now so it's normal to have some delay in patch > review. Maintainers often use this time to

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

On 01/09/2016 07:31, Ashijeet Acharya wrote: > I am still waiting for review on this one. Hi, QEMU is in hard freeze now so it's normal to have some delay in patch review. Maintainers often use this time to work on their own features. I'm sure John will get to it in short time. Paolo > On

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

I am still waiting for review on this one. On Tue, Aug 16, 2016 at 10:40 PM, Ashijeet Acharya wrote: > Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add > idebus_unrealize() in hw/ide/qdev.c to have calls to > qemu_del_vm_change_state_handler()

[Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Can you please resend this not as a reply to this discussion thread? http://wiki.qemu.org/Contribute/SubmitAPatch Thank you, --js On 08/16/2016 09:55 AM, Ashijeet Acharya wrote: Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to

[Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Fix a memory leak in ide_register_restart_cb() in hw/ide/core.c and add idebus_unrealize() in hw/ide/qdev.c to have calls to qemu_del_vm_change_state_handler() to deal with the dangling change state handler during hot-unplugging ide devices which might lead to a crash. Signed-off-by: Ashijeet

Re: [Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

On 11/08/2016 20:45, Ashijeet Acharya wrote: > Introduce VMChangeStateEntry parameter in ide_register_restart_cb() to handle > possible memory leak from qemu_add_vm_change_state_handler(). > > Signed-off-by: Ashijeet Acharya > --- > hw/ide/ahci.c | 2 +-

[Qemu-devel] [PATCH] Fix memory leak in ide_register_restart_cb()

Introduce VMChangeStateEntry parameter in ide_register_restart_cb() to handle possible memory leak from qemu_add_vm_change_state_handler(). Signed-off-by: Ashijeet Acharya --- hw/ide/ahci.c | 2 +- hw/ide/cmd646.c | 2 +- hw/ide/core.c