Re: [Qemu-devel] [PATCH] Fix memory leaks in ELF loader

2006-05-02 Thread Dirk Behme
Fabrice Bellard wrote: Why adding several labels ? qemu_free(NULL) is perfectly valid. I would just add the missing "qemu_free(phdr)" ... Okay. Wasn't sure about this ;) Do you want a patch for "qemu_free(phdr)"? Dirk ___ Qemu-devel mailing list Q

Re: [Qemu-devel] [PATCH] Fix memory leaks in ELF loader

2006-05-01 Thread Fabrice Bellard
Why adding several labels ? qemu_free(NULL) is perfectly valid. I would just add the missing "qemu_free(phdr)" ... Fabrice. Dirk Behme wrote: Fix memory leaks in ELF loader. Regards Dirk --- elf_ops.h_orig 2006

[Qemu-devel] [PATCH] Fix memory leaks in ELF loader

2006-05-01 Thread Dirk Behme
Fix memory leaks in ELF loader. Regards Dirk --- elf_ops.h_orig 2006-05-01 09:01:47.0 +0200 +++ elf_ops.h 2006-05-01 09:09:34.0 +0200 @@ -148,7 +148,7 @@ int glue(load_elf, SZ)(int fd, int64_t v uint8_t *data = NULL; if (read(fd, &ehdr, sizeof(ehdr)) != sizeo