Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-20 Thread David Gibson
On Fri, Nov 02, 2012 at 11:58:32AM +0100, Juan Quintela wrote: > David Gibson wrote: > > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: > >> On 10/31/2012 05:43 AM, David Gibson wrote: > >> > The code for migrating (or savevm-ing) memory pages starts off by > >> > creating > >> >

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-04 Thread David Gibson
On Sun, Nov 04, 2012 at 08:17:29PM +0100, Juan Quintela wrote: > David Gibson wrote: > > On Fri, Nov 02, 2012 at 11:58:32AM +0100, Juan Quintela wrote: > >> David Gibson wrote: > >> > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: > >> >> On 10/31/2012 05:43 AM, David Gibson wrot

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-04 Thread Juan Quintela
David Gibson wrote: > On Fri, Nov 02, 2012 at 11:58:32AM +0100, Juan Quintela wrote: >> David Gibson wrote: >> > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: >> >> On 10/31/2012 05:43 AM, David Gibson wrote: >> >> Reviewed-by: Juan Quintela >> >> Good catch, I missunderstoo

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-03 Thread David Gibson
On Fri, Nov 02, 2012 at 11:58:32AM +0100, Juan Quintela wrote: > David Gibson wrote: > > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: > >> On 10/31/2012 05:43 AM, David Gibson wrote: > >> > The code for migrating (or savevm-ing) memory pages starts off by > >> > creating > >> >

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-02 Thread Juan Quintela
David Gibson wrote: > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: >> On 10/31/2012 05:43 AM, David Gibson wrote: >> > The code for migrating (or savevm-ing) memory pages starts off by creating >> > a dirty bitmap and filling it with 1s. Except, actually, because bit >> > addre

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-01 Thread David Gibson
On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: > On 10/31/2012 05:43 AM, David Gibson wrote: > > The code for migrating (or savevm-ing) memory pages starts off by creating > > a dirty bitmap and filling it with 1s. Except, actually, because bit > > addresses are 0-based it fills e

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-10-31 Thread Orit Wasserman
On 10/31/2012 05:43 AM, David Gibson wrote: > The code for migrating (or savevm-ing) memory pages starts off by creating > a dirty bitmap and filling it with 1s. Except, actually, because bit > addresses are 0-based it fills every bit except bit 0 with 1s and puts an > extra 1 beyond the end of th

[Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-10-30 Thread David Gibson
The code for migrating (or savevm-ing) memory pages starts off by creating a dirty bitmap and filling it with 1s. Except, actually, because bit addresses are 0-based it fills every bit except bit 0 with 1s and puts an extra 1 beyond the end of the bitmap, potentially corrupting unrelated memory.