Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-05-03 Thread Alex Williamson
On Tue, 2011-05-03 at 15:15 +0200, Markus Armbruster wrote: > Alex Williamson writes: > > > When we're trying to get a newly registered phys memory client updated > > with the current page mappings, we end up passing the region offset > > (a ram_addr_t) as the start address rather than the actual

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-05-03 Thread Markus Armbruster
Alex Williamson writes: > When we're trying to get a newly registered phys memory client updated > with the current page mappings, we end up passing the region offset > (a ram_addr_t) as the start address rather than the actual guest > physical memory address (target_phys_addr_t). If your guest

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-05-01 Thread Michael S. Tsirkin
On Fri, Apr 29, 2011 at 06:31:03PM +0200, Jan Kiszka wrote: > On 2011-04-29 18:20, Alex Williamson wrote: > > On Fri, 2011-04-29 at 18:07 +0200, Jan Kiszka wrote: > >> On 2011-04-29 17:55, Alex Williamson wrote: > >>> On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: > On 2011-04-29 17:38,

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 09:38 -0600, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > > >> When we're trying to get a newly registered phys memory c

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 18:20, Alex Williamson wrote: > On Fri, 2011-04-29 at 18:07 +0200, Jan Kiszka wrote: >> On 2011-04-29 17:55, Alex Williamson wrote: >>> On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: On 2011-04-29 17:38, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:29 +0200, Jan Ki

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 18:07 +0200, Jan Kiszka wrote: > On 2011-04-29 17:55, Alex Williamson wrote: > > On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: > >> On 2011-04-29 17:38, Alex Williamson wrote: > >>> On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > On 2011-04-29 17:06, Michael

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 17:55, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: >> On 2011-04-29 17:38, Alex Williamson wrote: >>> On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: On 2011-04-29 17:06, Michael S. Tsirkin wrote: > On Thu, Apr 28, 2011 at 09:15:23PM -06

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: > On 2011-04-29 17:38, Alex Williamson wrote: > > On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > >> On 2011-04-29 17:06, Michael S. Tsirkin wrote: > >>> On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > When we're tr

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 17:38, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: >> On 2011-04-29 17:06, Michael S. Tsirkin wrote: >>> On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: When we're trying to get a newly registered phys memory client updated

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 18:34 +0300, Michael S. Tsirkin wrote: > On Fri, Apr 29, 2011 at 05:29:06PM +0200, Jan Kiszka wrote: > > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > > >> When we're trying to get a newly registered phy

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > >> When we're trying to get a newly registered phys memory client updated > >> with the current page mappings, we end up passi

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Michael S. Tsirkin
On Fri, Apr 29, 2011 at 05:29:06PM +0200, Jan Kiszka wrote: > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > >> When we're trying to get a newly registered phys memory client updated > >> with the current page mappings, we end u

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 17:06, Michael S. Tsirkin wrote: > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: >> When we're trying to get a newly registered phys memory client updated >> with the current page mappings, we end up passing the region offset >> (a ram_addr_t) as the start address r

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Michael S. Tsirkin
On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > When we're trying to get a newly registered phys memory client updated > with the current page mappings, we end up passing the region offset > (a ram_addr_t) as the start address rather than the actual guest > physical memory addres

[Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-28 Thread Alex Williamson
When we're trying to get a newly registered phys memory client updated with the current page mappings, we end up passing the region offset (a ram_addr_t) as the start address rather than the actual guest physical memory address (target_phys_addr_t). If your guest has less than 3.5G of memory, thes