Re: [Qemu-devel] [PATCH] Fix recently introduced bugs in -usbdevice host

2009-11-27 Thread Gerd Hoffmann
On 11/27/09 13:05, Markus Armbruster wrote: Commit 26a9e82a has the following flaws: ACK, the fixes are correct. /me used to test with -device usb-host, mostly and obviously didn't pay enougth attention to the -usbdevice backward compatibility code paths. thanks for fixing it up, Gerd

[Qemu-devel] [PATCH] Fix recently introduced bugs in -usbdevice host

2009-11-27 Thread Markus Armbruster
Commit 26a9e82a has the following flaws: * It enabled DEBUG. * It referenced two properties by the wrong name in usb_host_device_open(), which crashes with "qdev_prop_set: property "USB Host Device.bus" not found". * It broke "-usbdevice host:auto:..." by calling parse_filter() incorrectly