Am 18.09.2009 um 18:18 schrieb G 3:

This patch eliminates all the warnings and errors that appear when compiling cocoa.m on Mac OS 10.4 and under.

Signed-off-by: John Arbuckle <programmingk...@gmail.com>
---
cocoa.m |   25 ++++++++++++++++---------
1 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/cocoa.m b/cocoa.m
index 55ff2b4..cb75e3e 100644
--- a/cocoa.m
+++ b/cocoa.m
@@ -23,11 +23,17 @@
 */

#import <Cocoa/Cocoa.h>
-
#include "qemu-common.h"
#include "console.h"
#include "sysemu.h"

+#ifndef MAC_OS_X_VERSION_10_4
+#define MAC_OS_X_VERSION_10_4 1040
+#endif

I've picked this part up...

@@ -421,7 +429,7 @@ int cocoa_keycode_to_qemu(int keycode)
        [self ungrabMouse];
        [self setContentDimensions];
// test if host support "enterFullScreenMode:withOptions" at compiletime
-#if (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_4)
+#if (MAC_OS_X_VERSION_MAX_ALLOWED > MAC_OS_X_VERSION_10_4)
if ([NSView respondsToSelector:@selector(exitFullScreenModeWithOptions:)]) { // test if "exitFullScreenModeWithOptions" is supported on host at runtime
            [self exitFullScreenModeWithOptions:nil];
        } else {

... but why do you do these changes? On v10.4 respondsToSelector: should simply return NO at runtime and not call the method. Are there warnings?

Andreas


Reply via email to