[Qemu-devel] [PATCH] Ignore pci unplug requests for unpluggable devices (CVE-2011-1751)

2011-05-19 Thread Gerd Hoffmann
This patch makes qemu ignore unplug requests from the guest for pci devices which are tagged as non-hotpluggable. Trouble spot is the piix4 chipset with the ISA bridge. Requests to unplug that one will make it go away together with all ISA bus devices, which are not prepared to be unplugged and

Re: [Qemu-devel] [PATCH] Ignore pci unplug requests for unpluggable devices (CVE-2011-1751)

2011-05-19 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: This patch makes qemu ignore unplug requests from the guest for pci devices which are tagged as non-hotpluggable. Trouble spot is the piix4 chipset with the ISA bridge. Requests to unplug that one will make it go away together with all ISA bus

Re: [Qemu-devel] [PATCH] Ignore pci unplug requests for unpluggable devices (CVE-2011-1751)

2011-05-19 Thread Gerd Hoffmann
Hi, diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index 96f5222..6c908ff 100644 --- a/hw/acpi_piix4.c +++ b/hw/acpi_piix4.c @@ -471,11 +471,13 @@ static void pciej_write(void *opaque, uint32_t addr, uint32_t val) BusState *bus = opaque; DeviceState *qdev, *next; PCIDevice

Re: [Qemu-devel] [PATCH] Ignore pci unplug requests for unpluggable devices (CVE-2011-1751)

2011-05-19 Thread Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes: Hi, Markus Armbruster arm...@redhat.com writes: Gerd Hoffmann kra...@redhat.com writes: This patch makes qemu ignore unplug requests from the guest for pci devices which are tagged as non-hotpluggable. Trouble spot is the piix4 chipset with the

Re: [Qemu-devel] [PATCH] Ignore pci unplug requests for unpluggable devices (CVE-2011-1751)

2011-05-19 Thread Isaku Yamahata
On Thu, May 19, 2011 at 01:23:18PM +0200, Markus Armbruster wrote: Gerd Hoffmann kra...@redhat.com writes: Hi, Markus Armbruster arm...@redhat.com writes: Gerd Hoffmann kra...@redhat.com writes: This patch makes qemu ignore unplug requests from the guest for pci devices which