Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-07-08 Thread Peter Maydell
On 4 July 2014 15:33, Peter Maydell peter.mayd...@linaro.org wrote: On 30 June 2014 13:09, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/06/2014 18:59, Peter Maydell ha scritto: Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-07-04 Thread Peter Maydell
On 30 June 2014 13:09, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/06/2014 18:59, Peter Maydell ha scritto: Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing sometimes, because it means that when Make does its is any makefile or

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-07-04 Thread Paolo Bonzini
Il 04/07/2014 16:33, Peter Maydell ha scritto: On 30 June 2014 13:09, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/06/2014 18:59, Peter Maydell ha scritto: Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing sometimes, because it means

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Paolo Bonzini
Il 28/06/2014 18:59, Peter Maydell ha scritto: Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing sometimes, because it means that when Make does its is any makefile or include out of date and needing a rebuild? check, as well as possibly

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Peter Maydell
On 30 June 2014 13:09, Paolo Bonzini pbonz...@redhat.com wrote: Il 28/06/2014 18:59, Peter Maydell ha scritto: Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing sometimes, because it means that when Make does its is any makefile or

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 14:13, Peter Maydell ha scritto: config-devices.mak is not reflected in any C header file. Apart from this, Reviewed-by: Paolo Bonzini pbonz...@redhat.com Do you mean ...and therefore should not be listed on the RHS of this dependency ? It need not be listed; it doesn't hurt

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Peter Maydell
On 30 June 2014 13:34, Paolo Bonzini pbonz...@redhat.com wrote: Il 30/06/2014 14:13, Peter Maydell ha scritto: config-devices.mak is not reflected in any C header file. Apart from this, Reviewed-by: Paolo Bonzini pbonz...@redhat.com Do you mean ...and therefore should not be listed on

Re: [Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-30 Thread Paolo Bonzini
Il 30/06/2014 14:42, Peter Maydell ha scritto: In that case I will leave it be rather than re-rolling :-) (Maybe one day we'll have a header that does reflect it...) So far we never had the need and Blue Swirl objected to it (in favor of run-time probing of QOM classes), but you never know.

[Qemu-devel] [PATCH] Makefile: Don't build generated headers before Makefile is reread

2014-06-28 Thread Peter Maydell
Having a direct dependency Makefile: $(GENERATED_HEADERS) can result in not-from-clean builds failing sometimes, because it means that when Make does its is any makefile or include out of date and needing a rebuild? check, as well as possibly running configure (to update config-host.mak) it