Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

2014-04-29 Thread Michael Tokarev
29.04.2014 10:29, Paolo Bonzini wrote: [] > What about this instead, does it do the same? > > diff --git a/rules.mak b/rules.mak > index 5c454d8..7038576 100644 > --- a/rules.mak > +++ b/rules.mak > @@ -228,6 +228,7 @@ endef > define unnest-vars > $(eval obj := $1) > $(eval nested-vars := $2) >

Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

2014-04-29 Thread Paolo Bonzini
Il 29/04/2014 09:28, Fam Zheng ha scritto: > > What about this instead, does it do the same? Yes, it's better! Ok, I'll take care of this patch then. Paolo

Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

2014-04-29 Thread Fam Zheng
On Tue, 04/29 08:29, Paolo Bonzini wrote: > Il 29/04/2014 05:29, Fam Zheng ha scritto: > > The compiling is done in a subdir, so the extraction of per-object libs > > and cflags are referencing objects with ../ prefixed. So prefix the > > per-object variables "foo.o-cflags" and "foo.o-libs" to > >

Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

2014-04-28 Thread Paolo Bonzini
Il 29/04/2014 05:29, Fam Zheng ha scritto: > The compiling is done in a subdir, so the extraction of per-object libs > and cflags are referencing objects with ../ prefixed. So prefix the > per-object variables "foo.o-cflags" and "foo.o-libs" to > "../foo.o-cflags" and "../foo.o-libs". > > Signed-o

Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

2014-04-28 Thread Michael Tokarev
29.04.2014 07:29, Fam Zheng wrote: > The compiling is done in a subdir, so the extraction of per-object libs > and cflags are referencing objects with ../ prefixed. So prefix the > per-object variables "foo.o-cflags" and "foo.o-libs" to > "../foo.o-cflags" and "../foo.o-libs". > > Signed-off-by: F

[Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

2014-04-28 Thread Fam Zheng
The compiling is done in a subdir, so the extraction of per-object libs and cflags are referencing objects with ../ prefixed. So prefix the per-object variables "foo.o-cflags" and "foo.o-libs" to "../foo.o-cflags" and "../foo.o-libs". Signed-off-by: Fam Zheng --- Makefile.target | 11 ++-