Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-16 Thread Anthony Liguori
On 11/09/2010 01:36 AM, Gleb Natapov wrote: Properly check array bounds before accessing array element. Signed-off-by: Gleb Natapov Applied. Thanks. Regards, Anthony Liguori diff --git a/hw/usb-net.c b/hw/usb-net.c index 70f9263..84e2d79 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-16 Thread Gleb Natapov
On Tue, Nov 16, 2010 at 02:08:13PM -0600, Anthony Liguori wrote: > On 11/09/2010 04:51 AM, Markus Armbruster wrote: > >Gleb Natapov writes: > > > >>On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote: > >>>Gleb Natapov writes: > >>> > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Ma

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-16 Thread Anthony Liguori
On 11/09/2010 04:51 AM, Markus Armbruster wrote: Gleb Natapov writes: On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote: Gleb Natapov writes: On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: Gleb Natapov writes:

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Markus Armbruster
Gleb Natapov writes: > On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> > Properly check array bounds before accessing array element. >>

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Gleb Natapov
On Tue, Nov 09, 2010 at 11:16:43AM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: > >> Gleb Natapov writes: > >> > >> > Properly check array bounds before accessing array element. > >> > >> Impact? > >> > > Gappi

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Markus Armbruster
Gleb Natapov writes: > On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > Properly check array bounds before accessing array element. >> >> Impact? >> > Gapping security hole for those unfortunate enough to use usb-net? Doesn't that bit of info

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Gleb Natapov
On Tue, Nov 09, 2010 at 10:30:54AM +0100, Markus Armbruster wrote: > Gleb Natapov writes: > > > Properly check array bounds before accessing array element. > > Impact? > Gapping security hole for those unfortunate enough to use usb-net? > Apply to stable as well? > Definitely. Actually for me

Re: [Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-09 Thread Markus Armbruster
Gleb Natapov writes: > Properly check array bounds before accessing array element. Impact? Apply to stable as well? > Signed-off-by: Gleb Natapov > diff --git a/hw/usb-net.c b/hw/usb-net.c > index 70f9263..84e2d79 100644 > --- a/hw/usb-net.c > +++ b/hw/usb-net.c > @@ -1142,7 +1142,7 @@ static

[Qemu-devel] [PATCH] Out off array access in usb-net

2010-11-08 Thread Gleb Natapov
Properly check array bounds before accessing array element. Signed-off-by: Gleb Natapov diff --git a/hw/usb-net.c b/hw/usb-net.c index 70f9263..84e2d79 100644 --- a/hw/usb-net.c +++ b/hw/usb-net.c @@ -1142,7 +1142,7 @@ static int usb_net_handle_control(USBDevice *dev, int request, int value,