Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Kevin Wolf
Am 15.08.2012 10:13, schrieb ronnie sahlberg: > Acked-by: Ronnie Sahlberg > > > > On Wed, Aug 15, 2012 at 5:09 PM, Stefan Priebe wrote: >> Signed-off-by: Stefan Priebe >> >> --- >> block/iscsi.c | 55 +++ >> 1 files changed, 23 insertions

Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread ronnie sahlberg
Acked-by: Ronnie Sahlberg On Wed, Aug 15, 2012 at 5:09 PM, Stefan Priebe wrote: > Signed-off-by: Stefan Priebe > > --- > block/iscsi.c | 55 +++ > 1 files changed, 23 insertions(+), 32 deletions(-) > > diff --git a/block/iscsi.c b/block/i

Re: [Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe - Profihost AG
This patch fixes two main issues with block/iscsi.c: 1.) iscsi_task_mgmt_abort_task_async calls iscsi_scsi_task_cancel which was also directly called in iscsi_aio_cancel 2.) a race between task completition and task abortion could happen cause the scsi_free_scsi_task were done before

[Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe
Signed-off-by: Stefan Priebe --- block/iscsi.c | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 12ca76d..1c8b049 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -76,6 +76,10 @@ s

[Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-15 Thread Stefan Priebe
--- block/iscsi.c | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 12ca76d..1c8b049 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -76,6 +76,10 @@ static void iscsi_abort_task_cb

[Qemu-devel] [PATCH] PATCH V2: fix NULL dereferences / races between task completition and abort

2012-08-14 Thread Stefan Priebe
Signed-off-by: Stefan Priebe --- block/iscsi.c | 55 +++ 1 files changed, 23 insertions(+), 32 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index 12ca76d..1c8b049 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -76,6 +76,10 @@ s