Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
> On 8 January 2012 19:44, Marek Vasut wrote: > > It's just their position that's different indeed. And even this can be > > tuned via props. I'll update the patch once I get FEC operational. > > Incidentally, since this is only needed for a platform we don't > currently support, you should submi

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 8 January 2012 19:44, Marek Vasut wrote: > It's just their position that's different indeed. And even this can be tuned > via > props. I'll update the patch once I get FEC operational. Incidentally, since this is only needed for a platform we don't currently support, you should submit the pat

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
> On 8 January 2012 16:57, Marek Vasut wrote: > >Peter Maydell wrote: > >> Does the hardware give the ID registers the same values as stock > >> PL011 or are the part number/designer/etc fields different? > > > > Slightly different, but compatible with Linux: > > > > 80075fe0: 0011 0010

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 8 January 2012 16:57, Marek Vasut wrote: >Peter Maydell wrote: >> Does the hardware give the ID registers the same values as stock >> PL011 or are the part number/designer/etc fields different? > > Slightly different, but compatible with Linux: > > 80075fe0: 0011 0010 0024

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
> On 8 January 2012 16:02, Marek Vasut wrote: > >> Can you point me to some documentation? I looked at > >> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch= > >> 1&s r=7 (i.MX28 Applications Processor Reference Manual) and although it > >> has a number of UARTs none of them

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 8 January 2012 16:02, Marek Vasut wrote: >> Can you point me to some documentation? I looked at >> http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch=1&s >> r=7 (i.MX28 Applications Processor Reference Manual) and although it has a >> number of UARTs none of them looked obv

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
> On 7 January 2012 20:56, Marek Vasut wrote: > >> On 7 January 2012 20:11, Marek Vasut wrote: > >> > The AMBA IDs are supposed to be at the end of 0x2000 block, which the > >> > PL011 UART allocates. Current QEMU implementation puts those IDs at > >> > 0x1000 offset, which is wrong. The QEMU imp

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 7 January 2012 20:56, Marek Vasut wrote: >> On 7 January 2012 20:11, Marek Vasut wrote: >> > The AMBA IDs are supposed to be at the end of 0x2000 block, which the >> > PL011 UART allocates. Current QEMU implementation puts those IDs at >> > 0x1000 offset, which is wrong. The QEMU implementatio

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-07 Thread Marek Vasut
> On 7 January 2012 20:11, Marek Vasut wrote: > > The AMBA IDs are supposed to be at the end of 0x2000 block, which the > > PL011 UART allocates. Current QEMU implementation puts those IDs at > > 0x1000 offset, which is wrong. The QEMU implementation also allocates > > only 0x1000 instead of 0x200

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-07 Thread Peter Maydell
On 7 January 2012 20:11, Marek Vasut wrote: > The AMBA IDs are supposed to be at the end of 0x2000 block, which the PL011 > UART > allocates. Current QEMU implementation puts those IDs at 0x1000 offset, which > is > wrong. The QEMU implementation also allocates only 0x1000 instead of 0x2000 of >

[Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-07 Thread Marek Vasut
The AMBA IDs are supposed to be at the end of 0x2000 block, which the PL011 UART allocates. Current QEMU implementation puts those IDs at 0x1000 offset, which is wrong. The QEMU implementation also allocates only 0x1000 instead of 0x2000 of space. The fix is tested to work with Linux's PL011 drive