Re: [Qemu-devel] [PATCH] RFC: delay pci_update_mappings for 64-bit BARs

2010-12-15 Thread Isaku Yamahata
On Tue, Dec 14, 2010 at 10:42:43AM -0700, Cam Macdonell wrote: > On Mon, Dec 13, 2010 at 8:00 PM, Isaku Yamahata > wrote: > > On Mon, Dec 13, 2010 at 03:43:44PM -0700, Cam Macdonell wrote: > >> Do not call pci_update_mappings on the lower 32-bits of a 64-bit bar. > >> ?Wait for the upper 32 or e

Re: [Qemu-devel] [PATCH] RFC: delay pci_update_mappings for 64-bit BARs

2010-12-14 Thread Cam Macdonell
On Mon, Dec 13, 2010 at 8:00 PM, Isaku Yamahata wrote: > On Mon, Dec 13, 2010 at 03:43:44PM -0700, Cam Macdonell wrote: >> Do not call pci_update_mappings on the lower 32-bits of a 64-bit bar.  Wait >> for the upper 32 or else Qemu will try to map on just the lower 32 which is >> probably going

Re: [Qemu-devel] [PATCH] RFC: delay pci_update_mappings for 64-bit BARs

2010-12-13 Thread Isaku Yamahata
On Mon, Dec 13, 2010 at 03:43:44PM -0700, Cam Macdonell wrote: > Do not call pci_update_mappings on the lower 32-bits of a 64-bit bar. Wait > for the upper 32 or else Qemu will try to map on just the lower 32 which is > probably going to corrupt memory. > > I was encountering crashes when mappi

[Qemu-devel] [PATCH] RFC: delay pci_update_mappings for 64-bit BARs

2010-12-13 Thread Cam Macdonell
Do not call pci_update_mappings on the lower 32-bits of a 64-bit bar. Wait for the upper 32 or else Qemu will try to map on just the lower 32 which is probably going to corrupt memory. I was encountering crashes when mapping certain PCI region sizes. The problem turns out that pci_update_mapp