Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

2017-03-23 Thread Paolo Bonzini
On 23/03/2017 08:34, Pavel Dovgalyuk wrote: > This value is used by mc146818rtc. > Therefore it affects the vitrual machine state. It is used indeed, but it should not be used across virtual machine migration or savevm. The value doesn't matter as soon as apic_get_irq_delivered is called,

Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

2017-03-23 Thread Pavel Dovgalyuk
This value is used by mc146818rtc. Therefore it affects the vitrual machine state. I've encountered the cases when replay was broken without migrating of this variable. ⁣Отправлено с помощью BlueMail ​ На 22 Мар 2017 г., 15:13, в 15:13, Paolo Bonzini написал:>This reverts

Re: [Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

2017-03-23 Thread Peter Xu
On Wed, Mar 22, 2017 at 01:13:44PM +0100, Paolo Bonzini wrote: > This reverts commit 07bfa354772f2de67008dc66c201b627acff0106. > The global variable is only read as part of a > > apic_reset_irq_delivered(); > qemu_irq_raise(s->irq); > if

[Qemu-devel] [PATCH] Revert "apic: save apic_delivered flag"

2017-03-22 Thread Paolo Bonzini
This reverts commit 07bfa354772f2de67008dc66c201b627acff0106. The global variable is only read as part of a apic_reset_irq_delivered(); qemu_irq_raise(s->irq); if (!apic_get_irq_delivered()) { sequence, so the value never matters at migration time.